All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] python3: add patch to fix PEP 3147 issue with automake built packages
Date: Fri, 13 Nov 2015 08:02:43 +0100	[thread overview]
Message-ID: <56458B13.2070806@mind.be> (raw)
In-Reply-To: <20151112163129.4adc5852@PAL-U515208D001>

On 12-11-15 16:31, Christophe Vu-Brugier wrote:
> Hi Thomas,
> 
> On Thu, 5 Nov 2015 00:04:20 +0100, Thomas Petazzoni wrote :
>> In fact, it seems that this patch might be causing some Python 3 build
>> issues. See
>> http://autobuild.buildroot.org/results/06e/06e7c654a10a7618c0c64c57bfd9f27e770138fc/build-end.log.
>>
>> Can you have a look?
> 
> Sorry for the late reply.
> 
> Here is a short explanation for the error. The Makefile defines a rule
> to regenerate "Python/importlib.h" if "Lib/importlib/_bootstrap.py" is
> modified using a C helper named `_freeze_importlib`. Since
> "_boostrap.py" is modified by my patch, the rule is invoked. The
> problem is that the helper is built for the target so it cannot be
> executed on the host.
> 
> If I understand correctly "importlib.h" is a frozen module: it contains
> bytecode generated from "_bootstrap.py". It is only used by a dummy
> "frozen.c" program.

 Isn't importlib.h installed to STAGING_DIR where it could be picked up by other
modules?

> 
> I see two options:
> 
> 1/ Patch the Makefile to invoke a version of `_freeze_importlib` built
>    for the host.
> 2/ Simply do not regenerate "importlib.h" because it is not used.

 Most likely, the generated importlib.h doesn't change due to your patch. So the
simplest solution is to do a 'touch $(@D)/Python/importlib.h' in a post-patch
hook (with a large comment explaining why it is necessary and allowed).


 Regards,
 Arnout

> 
> I would favor the second option.
> 
> With best regards,
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-11-13  7:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 12:21 [Buildroot] [PATCH v2] python3: add patch to fix PEP 3147 issue with automake built packages Christophe Vu-Brugier
2015-11-04 21:55 ` Thomas Petazzoni
2015-11-04 23:04   ` Thomas Petazzoni
2015-11-12 15:31     ` Christophe Vu-Brugier
2015-11-13  7:02       ` Arnout Vandecappelle [this message]
2015-11-13 21:45         ` Peter Korsgaard
2015-11-14 16:01           ` Christophe Vu-Brugier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56458B13.2070806@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.