From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 1/3] KVM: x86: set KVM_REQ_EVENT on local interupt request from user space Date: Fri, 13 Nov 2015 09:56:16 +0100 Message-ID: <5645A5B0.6000607@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Steve Rutherford To: Matt Gingell , kvm@vger.kernel.org Return-path: Received: from mail-wm0-f54.google.com ([74.125.82.54]:33101 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751978AbbKMI4T (ORCPT ); Fri, 13 Nov 2015 03:56:19 -0500 Received: by wmec201 with SMTP id c201so70689762wme.0 for ; Fri, 13 Nov 2015 00:56:18 -0800 (PST) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 12/11/2015 20:08, Matt Gingell wrote: > Set KVM_REQ_EVENT when a PIC in user space injects a local interrupt. > > Currently a request is only made when neither the PIC nor the APIC is in > the kernel, which is not sufficient in the split IRQ chip case. > > This addresses a problem in QEMU where interrupts are delayed until > another path invokes the event loop. > > Reviewed-by: Andy Honig > Signed-off-by: Matt Gingell > --- > arch/x86/kvm/x86.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 30723a4..456973b 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -2683,6 +2683,7 @@ static int kvm_vcpu_ioctl_interrupt(struct kvm_vcpu *vcpu, > return -EEXIST; > > vcpu->arch.pending_external_vector = irq->irq; > + kvm_make_request(KVM_REQ_EVENT, vcpu); > return 0; > } > > Reviewed-by: Paolo Bonzini