From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCHv3] 26/28] build: convert HAS_GICV3 use to
 Kconfig
Date: Fri, 13 Nov 2015 11:17:48 +0000
Message-ID: <5645C6DC.2070202@citrix.com>
References: <1447368869-17360-1-git-send-email-cardoe@cardoe.com>
	<1447368869-17360-27-git-send-email-cardoe@cardoe.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1447368869-17360-27-git-send-email-cardoe@cardoe.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Hi Doug,

On 12/11/15 22:54, Doug Goldstein wrote:
> Use the Kconfig generated CONFIG_HAS_GICV3 defines in the code base.
> 
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> ---
>  xen/arch/arm/Kconfig         | 5 +++++
>  xen/arch/arm/Makefile        | 2 +-
>  xen/arch/arm/Rules.mk        | 2 --
>  xen/arch/arm/vgic.c          | 2 +-
>  xen/include/asm-arm/domain.h | 3 ++-
>  xen/include/asm-arm/gic.h    | 4 ++--
>  xen/include/asm-arm/vgic.h   | 2 +-

I was expecting you to drop variable HAS_GICV3 in config/arm64.mk.

BTW, this remark is also valid for most of the patch in this series.
Configuration variable may live either in arch/*/Rules.mk or in config/*.mk.

>  7 files changed, 12 insertions(+), 8 deletions(-)

[..]

> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> index e7e40da..1ce5e0b 100644
> --- a/xen/include/asm-arm/domain.h
> +++ b/xen/include/asm-arm/domain.h
> @@ -102,7 +102,8 @@ struct arch_domain
>          struct pending_irq *pending_irqs;
>          /* Base address for guest GIC */
>          paddr_t dbase; /* Distributor base address */
> -#ifdef HAS_GICV3
> +        paddr_t cbase; /* CPU base address */
> +#ifdef CONFIG_HAS_GICV3

As already said this on v1, can you please make sure that you series
don't re-introduce code or change it.

This should be pretty easy to check with grep. I.e any changes in *.c
and *.h files but in lines containing ifdef/endif are likely wrong.

>          /* GIC V3 addressing */
>          /* List of contiguous occupied by the redistributors */
>          struct vgic_rdist_region {

Regards,

-- 
Julien Grall