From: Guenter Roeck <linux@roeck-us.net>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: input: i8042: build failure on powerpc
Date: Fri, 13 Nov 2015 06:45:57 -0800 [thread overview]
Message-ID: <5645F7A5.7020002@roeck-us.net> (raw)
In-Reply-To: <20151113083559.GA12869@Red>
On 11/13/2015 12:35 AM, LABBE Corentin wrote:
> On Thu, Nov 12, 2015 at 07:41:17AM -0800, Guenter Roeck wrote:
>> On Thu, Nov 12, 2015 at 04:01:45PM +0100, LABBE Corentin wrote:
>>> Hello
>>>
>>> I have made a random .config for testing my powerpc cross-compiler and I got this fail:
>>>
>>
>> In general it helps to provide the broken configuration.
>>
>> If you do some digging, you may notice that this has been broken
>> since commit 917f0af9e5a9 ("powerpc: Remove arch/ppc and include/asm-ppc"),
>> or in other words since 2008. CONFIG_INPUT is not set with walnut_defconfig,
>> which may explain why no one noticed.
>>
>> I would suggest to just remove the offending code. Quite obviously it is dead.
>>
>
> Just for be clear, you suggest that I make a patch for removing powerpc support of the i8042 driver ?
> I have add linuxppc-dev@lists.ozlabs.org to the discution.
>
s/powerpc/walnut/
Guenter
> Regards
>
>>> LD init/built-in.o
>>> drivers/built-in.o: In function `i8042_wait_write':
>>> i8042.c:(.text+0x13d8be): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13d8c6): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13d8e6): undefined reference to `kb_cs'
>>> drivers/built-in.o: In function `i8042_kbd_write':
>>> i8042.c:(.text+0x13d9aa): undefined reference to `kb_data'
>>> i8042.c:(.text+0x13d9ae): undefined reference to `kb_data'
>>> drivers/built-in.o: In function `i8042_flush':
>>> i8042.c:(.text+0x13da56): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13da62): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13da66): undefined reference to `kb_data'
>>> i8042.c:(.text+0x13da86): undefined reference to `kb_data'
>>> drivers/built-in.o: In function `i8042_panic_blink':
>>> i8042.c:(.text+0x13db92): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13db9a): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13dc06): undefined reference to `kb_data'
>>> i8042.c:(.text+0x13dc16): undefined reference to `kb_data'
>>> i8042.c:(.text+0x13dc8a): undefined reference to `kb_data'
>>> drivers/built-in.o: In function `i8042_interrupt':
>>> i8042.c:(.text+0x13dd1a): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13dd1e): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13dd3e): undefined reference to `kb_data'
>>> i8042.c:(.text+0x13dd42): undefined reference to `kb_data'
>>> drivers/built-in.o: In function `__i8042_command':
>>> i8042.c:(.text+0x13e2b6): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13e2be): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13e2ea): undefined reference to `kb_data'
>>> i8042.c:(.text+0x13e302): undefined reference to `kb_data'
>>> i8042.c:(.text+0x13e34e): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13e362): undefined reference to `kb_cs'
>>> i8042.c:(.text+0x13e366): undefined reference to `kb_data'
>>> i8042.c:(.text+0x13e3de): undefined reference to `kb_data'
>>> drivers/built-in.o: In function `i8042_aux_test_irq':
>>> i8042.c:(.init.text+0x59a2): undefined reference to `kb_cs'
>>> i8042.c:(.init.text+0x59a6): undefined reference to `kb_cs'
>>> i8042.c:(.init.text+0x59ca): undefined reference to `kb_data'
>>> i8042.c:(.init.text+0x59ce): undefined reference to `kb_data'
>>> drivers/built-in.o: In function `i8042_probe':
>>> i8042.c:(.init.text+0x5dda): undefined reference to `kb_cs'
>>> i8042.c:(.init.text+0x5dde): undefined reference to `kb_cs'
>>> i8042.c:(.init.text+0x6366): undefined reference to `kb_data'
>>> i8042.c:(.init.text+0x6376): undefined reference to `kb_cs'
>>> i8042.c:(.init.text+0x637a): undefined reference to `kb_data'
>>> Makefile:929: recipe for target 'vmlinux' failed
>>>
>>> it seems that kb_data and kb_cs (declared as extern in drivers/input/serio/i8042-ppcio.h) are defined anywhere.
>>>
>>> Regards
>
prev parent reply other threads:[~2015-11-13 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 15:01 input: i8042: build failure on powerpc LABBE Corentin
2015-11-12 15:41 ` Guenter Roeck
2015-11-13 8:35 ` LABBE Corentin
2015-11-13 14:45 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645F7A5.7020002@roeck-us.net \
--to=linux@roeck-us.net \
--cc=clabbe.montjoie@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.