From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] net: convert qemu_log to error_report
Date: Fri, 13 Nov 2015 07:54:17 -0700 [thread overview]
Message-ID: <5645F999.6040509@redhat.com> (raw)
In-Reply-To: <1447419494-10670-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On 11/13/2015 05:58 AM, Paolo Bonzini wrote:
> Ensure that the error is printed with the proper timestamp.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> net/dump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/net/dump.c b/net/dump.c
> index dd0555f..ab71ffc 100644
> --- a/net/dump.c
> +++ b/net/dump.c
> @@ -84,7 +84,7 @@ static ssize_t dump_receive_iov(DumpState *s, const struct iovec *iov, int cnt)
> cnt = iov_copy(&dumpiov[1], cnt, iov, cnt, 0, caplen);
>
> if (writev(s->fd, dumpiov, cnt + 1) != sizeof(hdr) + caplen) {
> - qemu_log("-net dump write error - stop dump\n");
> + error_report("-net dump write error - stop dump");
> close(s->fd);
> s->fd = -1;
> }
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] net: convert qemu_log to error_report
Date: Fri, 13 Nov 2015 07:54:17 -0700 [thread overview]
Message-ID: <5645F999.6040509@redhat.com> (raw)
In-Reply-To: <1447419494-10670-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
On 11/13/2015 05:58 AM, Paolo Bonzini wrote:
> Ensure that the error is printed with the proper timestamp.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> net/dump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/net/dump.c b/net/dump.c
> index dd0555f..ab71ffc 100644
> --- a/net/dump.c
> +++ b/net/dump.c
> @@ -84,7 +84,7 @@ static ssize_t dump_receive_iov(DumpState *s, const struct iovec *iov, int cnt)
> cnt = iov_copy(&dumpiov[1], cnt, iov, cnt, 0, caplen);
>
> if (writev(s->fd, dumpiov, cnt + 1) != sizeof(hdr) + caplen) {
> - qemu_log("-net dump write error - stop dump\n");
> + error_report("-net dump write error - stop dump");
> close(s->fd);
> s->fd = -1;
> }
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-11-13 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 12:58 [Qemu-trivial] [PATCH] net: convert qemu_log to error_report Paolo Bonzini
2015-11-13 12:58 ` [Qemu-devel] " Paolo Bonzini
2015-11-13 14:54 ` Eric Blake [this message]
2015-11-13 14:54 ` Eric Blake
2015-11-13 16:44 ` [Qemu-trivial] " Thomas Huth
2015-11-13 16:44 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645F999.6040509@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.