From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZxFrb-0001tI-Q8 for mharc-grub-devel@gnu.org; Fri, 13 Nov 2015 10:02:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxFra-0001qk-4W for grub-devel@gnu.org; Fri, 13 Nov 2015 10:02:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZxFrS-0007EO-Iq for grub-devel@gnu.org; Fri, 13 Nov 2015 10:02:06 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:50219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZxFrS-0007EC-EQ for grub-devel@gnu.org; Fri, 13 Nov 2015 10:01:58 -0500 Received: from pps.filterd (m0001255.ppops.net [127.0.0.1]) by mx0b-00082601.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id tADEuu9h015513; Fri, 13 Nov 2015 07:01:55 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=subject : to : references : cc : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=2Y46h77+3+VxyYO9LmX4Yro//VyPYx1PnUh6LmpODf0=; b=BT03dkak8p4P4WkatGsOX8H+skM1gHQC7Z8gIN2RPa0Pda61pQxYWveaOk1oQrCsS/Ud 4MGkKYKC8IrN7Lp2JRyU7QkOZeCQuAnAp+e8K7tKB7kewPAHKJW6GEzAMV+ydF94qFeI JJvV4Beylav0J6hOXBybRmFnxNKLJuTpxxI= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0b-00082601.pphosted.com with ESMTP id 1y1e06xtv5-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 13 Nov 2015 07:01:55 -0800 Received: from localhost.localdomain (192.168.52.123) by mail.thefacebook.com (192.168.16.16) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 13 Nov 2015 07:01:52 -0800 Subject: Re: [PATCH] efinet: check for broken firmware To: Andrei Borzenkov References: <1447366056-3328165-1-git-send-email-jbacik@fb.com> <5645F3F9.7030405@fb.com> From: Josef Bacik Message-ID: <5645FB5E.9040804@fb.com> Date: Fri, 13 Nov 2015 10:01:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2015-11-13_12:, , signatures=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 67.231.153.30 Cc: The development of GNU GRUB , kernel-team@fb.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 15:02:07 -0000 On 11/13/2015 09:38 AM, Andrei Borzenkov wrote: > On Fri, Nov 13, 2015 at 5:30 PM, Josef Bacik wrote: >>>> @@ -291,6 +286,9 @@ grub_efinet_findcards (void) >>>> 0, &num_handles); >>>> if (! handles) >>>> return; >>>> + >>>> + attributes = grub_snp_attributes(); >>>> + >>>> for (handle = handles; num_handles--; handle++) >>>> { >>>> grub_efi_simple_network_t *net; >>>> @@ -319,8 +317,7 @@ grub_efinet_findcards (void) >>>> && GRUB_EFI_DEVICE_PATH_SUBTYPE (parent) == >>>> GRUB_EFI_MAC_ADDRESS_DEVICE_PATH_SUBTYPE) >>>> continue; >>>> >>>> - net = grub_efi_open_protocol (*handle, &net_io_guid, >>>> - GRUB_EFI_OPEN_PROTOCOL_GET_PROTOCOL); >>>> + net = grub_efi_open_protocol (*handle, &net_io_guid, attributes); >>> >>> >>> No, we cannot open exclusively here, it will destroy autocnfiguration >>> information we need later. You need to add conditional in open_card. >> >> >> The autoconfig stuff still works later for me but I can change it back. > > Thaty would mean your firmware probably is SNP based and not MNP > based. But it will definitely break autoconfig for others - was there, > done that :) > Fair enough, looks like this firmware is 2.3.1 so theoretically has MNP, I'll try and track down this solaris mnp driver and see if I can get it to work. Thanks, Josef