From: Tomas Henzl <thenzl@redhat.com>
To: Sreekanth Reddy <sreekanth.reddy@avagotech.com>, jejb@kernel.org
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
JBottomley@Parallels.com, Sathya.Prakash@avagotech.com,
kashyap.desai@avagotech.com, linux-kernel@vger.kernel.org,
hch@infradead.org, chaitra.basappa@avagotech.com,
suganath-prabu.subramani@avagotech.com
Subject: Re: [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag
Date: Fri, 13 Nov 2015 16:05:28 +0100 [thread overview]
Message-ID: <5645FC38.2070201@redhat.com> (raw)
In-Reply-To: <1447351837-31388-1-git-send-email-Sreekanth.Reddy@avagotech.com>
On 12.11.2015 19:10, Sreekanth Reddy wrote:
> Before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag in MPI SCSI IO
> request message, check whether TLR is enabled on the drive using
> 'sas_is_tlr_enabled' API.
>
> Actually in the driver code, driver is using below API's
>
> 1. sas_enable_tlr() - to enable the TLR
> 2. sas_disable_tlr() - to disable the TLR
> 3. sas_is_tlr_enabled() - to check whether TLR is enabled or not.
>
> but in scsih_qcmd() we have missed to use sas_is_tlr_enabled() API,
> instead we checking for TLR bit from flag field of driver's
> 'struct MPT3SAS_DEVIC' structure. which is corrected with this patch.
>
> Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@avagotech.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
next prev parent reply other threads:[~2015-11-13 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 18:10 [PATCH] mpt3sas: Fix use sas_is_tlr_enabled API before enabling MPI2_SCSIIO_CONTROL_TLR_ON flag Sreekanth Reddy
2015-11-13 7:24 ` Hannes Reinecke
2015-11-13 15:05 ` Tomas Henzl [this message]
2015-11-13 20:46 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645FC38.2070201@redhat.com \
--to=thenzl@redhat.com \
--cc=JBottomley@Parallels.com \
--cc=Sathya.Prakash@avagotech.com \
--cc=chaitra.basappa@avagotech.com \
--cc=hch@infradead.org \
--cc=jejb@kernel.org \
--cc=kashyap.desai@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sreekanth.reddy@avagotech.com \
--cc=suganath-prabu.subramani@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.