From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH XEN v5 02/23] tools: Refactor "xentoollog" into its own library Date: Fri, 13 Nov 2015 15:05:50 +0000 Message-ID: <5645FC4E.5000401@citrix.com> References: <1447070397.27774.11.camel@citrix.com> <1447070458-31104-1-git-send-email-ian.campbell@citrix.com> <1447070458-31104-3-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447070458-31104-3-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/11/15 12:00, Ian Campbell wrote: > diff --git a/tools/ocaml/Makefile.rules b/tools/ocaml/Makefile.rules > index 1796060..45e71f2 100644 > --- a/tools/ocaml/Makefile.rules > +++ b/tools/ocaml/Makefile.rules > @@ -1,18 +1,18 @@ > -ifdef V > - ifeq ("$(origin V)", "command line") > - BUILD_VERBOSE = $(V) > - endif > -endif > -ifndef BUILD_VERBOSE > - BUILD_VERBOSE = 0 > -endif > -ifeq ($(BUILD_VERBOSE),1) > +#ifdef V > +# ifeq ("$(origin V)", "command line") > +# BUILD_VERBOSE = $(V) > +# endif > +#endif > +#ifndef BUILD_VERBOSE > +# BUILD_VERBOSE = 0 > +#endif > +#ifeq ($(BUILD_VERBOSE),1) > E = @true > Q = > -else > - E = @echo > - Q = @ > -endif > +#else > +# E = @echo > +# Q = @ > +#endif This hunk looks like temporary debugging? ~Andrew