From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH XEN v5 19/23] tools/libs/call: Update some log messages to not refer to xc. Date: Fri, 13 Nov 2015 16:20:45 +0000 Message-ID: <56460DDD.6030209@citrix.com> References: <1447070397.27774.11.camel@citrix.com> <1447070458-31104-1-git-send-email-ian.campbell@citrix.com> <1447070458-31104-20-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447070458-31104-20-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 09/11/15 12:00, Ian Campbell wrote: > Signed-off-by: Ian Campbell > Acked-by: Wei Liu I agree with the sentiment, but the error message refer to the libxencall entry API, so a developer can match it back to the call in their code. ~Andrew > --- > tools/libs/call/linux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/libs/call/linux.c b/tools/libs/call/linux.c > index 906ca7e..80b505c 100644 > --- a/tools/libs/call/linux.c > +++ b/tools/libs/call/linux.c > @@ -88,7 +88,7 @@ void *osdep_alloc_pages(xencall_handle *xcall, unsigned int npages) > p = mmap(NULL, size, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_LOCKED, -1, 0); > if ( p == MAP_FAILED ) > { > - PERROR("xc_alloc_hypercall_buffer: mmap failed"); > + PERROR("alloc_pages: mmap failed"); > return NULL; > } > > @@ -97,7 +97,7 @@ void *osdep_alloc_pages(xencall_handle *xcall, unsigned int npages) > rc = madvise(p, npages * PAGE_SIZE, MADV_DONTFORK); > if ( rc < 0 ) > { > - PERROR("xc_alloc_hypercall_buffer: madvise failed"); > + PERROR("alloc_pages: madvise failed"); > goto out; > } >