From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/IO-APIC: fix setup of Xen internally used IRQs (take 2) Date: Fri, 13 Nov 2015 17:29:39 +0000 Message-ID: <56461E03.3060804@citrix.com> References: <564612AE02000078000B4CBB@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZxIAS-000347-Hg for xen-devel@lists.xenproject.org; Fri, 13 Nov 2015 17:29:44 +0000 In-Reply-To: <564612AE02000078000B4CBB@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org On 13/11/15 15:41, Jan Beulich wrote: > ..., i.e. namely that of a PCI serial card with an IRQ above the > legacy range. This had got broken by the switch to cpumask_any() in > cpu_mask_to_apicid_phys(). Fix this by allowing all CPUs for that IRQ > (via setup_vector_irq() properly updating a booting CPU's vector_irq[], > thus avoiding "No irq handler for vector" messages and the interrupt > not working). > > Cleanup coding style and types there at once. > > While doing this I also noticed that io_apic_set_pci_routing() can't > be quite right: It sets up the destination _before_ getting a vector > allocated (which on other than systems using the flat APIC mode > affects the possible destinations), and also didn't restrict affinity > to ->arch.cpu_mask (as established by assign_irq_vector()). > > Signed-off-by: Jan Beulich Appears to cover the issues identified from v1. Reviewed-by: Andrew Cooper