From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/IO-APIC: adjust setting of destinations
Date: Fri, 13 Nov 2015 17:43:20 +0000 [thread overview]
Message-ID: <56462138.1040501@citrix.com> (raw)
In-Reply-To: <56462ED602000078000B4DEA@prv-mh.provo.novell.com>
On 13/11/15 17:41, Jan Beulich wrote:
>>>> On 13.11.15 at 17:26, <andrew.cooper3@citrix.com> wrote:
>> On 13/11/15 15:44, Jan Beulich wrote:
>>> setup_IO_APIC_irqs() runs before APs get brought up, so using
>>> desc->arch.cpu_mask as best risks it being either empty or having bits
>>> for CPUs other than the BP set. Just use the APIC ID of the only
>>> online CPU directly. Replace a stray hard_smp_processor_id() at once.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Surely this stray hard_smp_processor_id() needs to be merged into your
>> previous patch to remove hard_smp_processor_id() ?
> Actually I should have said that the other one depends on this one.
> Which one to put that hunk in really doesn't matter much.
It would be cleaner to deal with all hard_smp_processor_id() together,
as the other hunk is this patch is a far more clear candidate for backport.
~Andrew
prev parent reply other threads:[~2015-11-13 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 15:44 [PATCH] x86/IO-APIC: adjust setting of destinations Jan Beulich
2015-11-13 16:26 ` Andrew Cooper
2015-11-13 17:41 ` Jan Beulich
2015-11-13 17:43 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56462138.1040501@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.