From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCHv3] 00/28] Kconfig conversion Date: Fri, 13 Nov 2015 16:47:22 -0600 Message-ID: <5646687A.2020805@cardoe.com> References: <1447368869-17360-1-git-send-email-cardoe@cardoe.com> <5645CC74.6000509@citrix.com> <564664A9.6020601@cardoe.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6947263788550657514==" Return-path: In-Reply-To: <564664A9.6020601@cardoe.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xen.org Cc: Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6947263788550657514== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rgma5tswQ6oUrBcArf79PKiqJNf1m0S8i" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rgma5tswQ6oUrBcArf79PKiqJNf1m0S8i Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/13/15 4:31 PM, Doug Goldstein wrote: > On 11/13/15 5:41 AM, Julien Grall wrote: >> Hi Doug, >> >> On 12/11/15 22:54, Doug Goldstein wrote: >>> The following series is a follow on to the Kconfig conversion patch s= eries. >>> There are still more components to convert however this is the bare m= inimal >>> to get everything working and get the options out of the existing mak= efiles. >>> >>> The CONFIG_HAS_ variables are there to match the behavior of the Linu= x >>> CONFIG_HAVE_ variables. The purpose is to say that this hardware/prof= ile/env >>> supports this option while the CONFIG_ variable states that this opti= on was >>> requested on/off by user intervention. >>> >>> Ultimately my goal is to allow for more parts of the hypervisor to be= turned >>> off at compile time and potentially make it easier to include more >>> experimental features by others which can be turned off by default. A= lso to >>> provide the one true location for all possible knobs in the source co= de. >>> >>> The patch series can be grabbed at: https://github.com/cardoe/xen.git= >>> The branch is: kconfig_v3 >>> >>> Changes since v2: >>> - drop x86_32 support (patch 2) >>> - fix make defconfig (patch 2) >>> - fix 'make -C xen' vs 'cd xen && make' behaving differently (patch 2= ) >>> - fix for ARM64 builds (added patch 3) >>> - At this point all targets are tested on x86_64, arm32, and arm64 wi= th >>> fresh clones and rebuilds. >> >> After this series, the resulting binary won't be the same. For instanc= e >> on ARM64 all the UART drivers are disabled. >> >> The user/test system should be able to get the same options enabled by= >> default with and without your series. >> >> I wasn't able to find any documentation how to use your Kconfig with >> Xen, so I've tried different things which don't work as I was expected= =2E >> >> 1) If I modify myself xen/.config to remove/add an option, the config >> won't be recheck and ignored >> 2) make menuconfig doesn't expose any options =3D> No possibility to >> select any UART on ARM. >> >> The latter is because how you define the option in the Kconfig: >> >> config HAS_EXYNOS4210 >> bool >> >> Without any text, it's not possible for the user to select this option= =2E >> >> Regards, >> >=20 > Ok. I'm also now understanding you previous hesitation with using HAS_.= > For my next update I'll make these available and I'm going to change > HAS_ to UART_ to give them a common prefix. >=20 I meant to give an example: https://github.com/cardoe/xen/commit/697dbea1277d765ba998274a2814fcc56a7f= 31c0 I'll do my best to update the rest of the series as soon as possible for the other reviews. --=20 Doug Goldstein --rgma5tswQ6oUrBcArf79PKiqJNf1m0S8i Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWRmh9XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvUnkEP+wa3MKiSx8hTfDvgJGHzhqM8 FHfuMUEf4BhO6eaTIcdZ+p+jGz7R4xHlwDMyVy80LeVIbB3mIU2G9iPdCdAl6Z2C UWQDfNQXJlDPkSPjVcTnPG8SVayFc6L+lyoVVMYwjR38Xxlr3b75FNfap2/JDZjW ZAQ6fFP/3MhENrOuhnv+HfIwSwtNSYFiocipkL+Rbqh2Ut0OovN1u0jy55se9EPi 34XPWEnzqI6062jPA6eu6gKsTT0iSmJFTM+fhB7czZJNFIcEfOmMD1h+ikfoK186 wQyvCdYYDWnJeOvCEgHSqZj9Uft8Jed3scziTW8sB51C0vZdZ4Aqju+wcO7QgzUH iacmDZEVF8RwKMtjnGS+Y4JvLwqVCjUNLO6ZW1hTjv8b1NJL9SqzP2DC5GnZuJWU GzmokptCsN6FQPu639NhNTAIED4Phw/7PZNc3MUI00c6nY/1mbgX/FwtpIiNlrIY cWwBFVn+e3stD5nVQmS0jpc89MPri82JBVfn8TXbtMBSpciI2/fJdvSxaQEMWW5X mO3Fg3DXA6Vwaw8ul7CRICh+/OI62D07ASG26GpoxNSkqmkx+1Adr1fK/+0rgHpm cnuBHKV1udUPG1+aeFJSe/Zdx3IfJjPGc533zlwlN4cC5IBpwsoLIxvOygPAKWEG LNerfqlqZztdAJK86T/C =lyQ5 -----END PGP SIGNATURE----- --rgma5tswQ6oUrBcArf79PKiqJNf1m0S8i-- --===============6947263788550657514== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6947263788550657514==--