From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Bondarenko Subject: Re: [PATCH v3 6/7] spi: imx: return error from dma channel request Date: Sat, 14 Nov 2015 11:05:31 +0100 Message-ID: <5647076B.3080709@gmail.com> References: <1446388901-6073-1-git-send-email-anton.bondarenko.sama@gmail.com> <1446388901-6073-7-git-send-email-anton.bondarenko.sama@gmail.com> <20151105085637.GJ8526@pengutronix.de> <563B7D1C.7010105@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, b38343-KZfg59tc24xl57MIdRCFDg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org, jiada_wang-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org To: Sascha Hauer Return-path: In-Reply-To: <563B7D1C.7010105-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 05.11.2015 17:00, Anton Bondarenko wrote: > On 05.11.2015 09:56, Sascha Hauer wrote: >> On Sun, Nov 01, 2015 at 03:41:40PM +0100, Anton Bondarenko wrote: >>> From: Anton Bondarenko >>> >>> On SDMA initialization return exactly the same error, which is >>> reported by dma_request_slave_channel_reason(), it is a preceding >>> change to defer SPI DMA initialization, if SDMA module is not yet >>> available. >> >> Maybe something like: "fix probe deferral when dmaengine is not yet >> available" in the subject line will better express that this is a patch >> that should be applied ASAP. Also you can move this up to the front of >> the series when resending. >> >> Sascha >> > > This patch itself does not implement deferral for spi-imx if dmaengine > not ready. The patch targets 2 things: give a bit more detailed error > information of SPI dma slave channel initialization error and provide a > basis for the next patch ([PATCH v3 7/7] spi: imx: defer spi > initialization, if DMA engine is pending). > > Regards, Anton Does anyone has other comments regarding this commit? Regards, Anton -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: anton.bondarenko.sama@gmail.com (Anton Bondarenko) Date: Sat, 14 Nov 2015 11:05:31 +0100 Subject: [PATCH v3 6/7] spi: imx: return error from dma channel request In-Reply-To: <563B7D1C.7010105@gmail.com> References: <1446388901-6073-1-git-send-email-anton.bondarenko.sama@gmail.com> <1446388901-6073-7-git-send-email-anton.bondarenko.sama@gmail.com> <20151105085637.GJ8526@pengutronix.de> <563B7D1C.7010105@gmail.com> Message-ID: <5647076B.3080709@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05.11.2015 17:00, Anton Bondarenko wrote: > On 05.11.2015 09:56, Sascha Hauer wrote: >> On Sun, Nov 01, 2015 at 03:41:40PM +0100, Anton Bondarenko wrote: >>> From: Anton Bondarenko >>> >>> On SDMA initialization return exactly the same error, which is >>> reported by dma_request_slave_channel_reason(), it is a preceding >>> change to defer SPI DMA initialization, if SDMA module is not yet >>> available. >> >> Maybe something like: "fix probe deferral when dmaengine is not yet >> available" in the subject line will better express that this is a patch >> that should be applied ASAP. Also you can move this up to the front of >> the series when resending. >> >> Sascha >> > > This patch itself does not implement deferral for spi-imx if dmaengine > not ready. The patch targets 2 things: give a bit more detailed error > information of SPI dma slave channel initialization error and provide a > basis for the next patch ([PATCH v3 7/7] spi: imx: defer spi > initialization, if DMA engine is pending). > > Regards, Anton Does anyone has other comments regarding this commit? Regards, Anton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751381AbbKNKFh (ORCPT ); Sat, 14 Nov 2015 05:05:37 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:35943 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbbKNKFe (ORCPT ); Sat, 14 Nov 2015 05:05:34 -0500 Subject: Re: [PATCH v3 6/7] spi: imx: return error from dma channel request To: Sascha Hauer References: <1446388901-6073-1-git-send-email-anton.bondarenko.sama@gmail.com> <1446388901-6073-7-git-send-email-anton.bondarenko.sama@gmail.com> <20151105085637.GJ8526@pengutronix.de> <563B7D1C.7010105@gmail.com> Cc: broonie@kernel.org, b38343@freescale.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vladimir_zapolskiy@mentor.com, jiada_wang@mentor.com From: Anton Bondarenko Message-ID: <5647076B.3080709@gmail.com> Date: Sat, 14 Nov 2015 11:05:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <563B7D1C.7010105@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.11.2015 17:00, Anton Bondarenko wrote: > On 05.11.2015 09:56, Sascha Hauer wrote: >> On Sun, Nov 01, 2015 at 03:41:40PM +0100, Anton Bondarenko wrote: >>> From: Anton Bondarenko >>> >>> On SDMA initialization return exactly the same error, which is >>> reported by dma_request_slave_channel_reason(), it is a preceding >>> change to defer SPI DMA initialization, if SDMA module is not yet >>> available. >> >> Maybe something like: "fix probe deferral when dmaengine is not yet >> available" in the subject line will better express that this is a patch >> that should be applied ASAP. Also you can move this up to the front of >> the series when resending. >> >> Sascha >> > > This patch itself does not implement deferral for spi-imx if dmaengine > not ready. The patch targets 2 things: give a bit more detailed error > information of SPI dma slave channel initialization error and provide a > basis for the next patch ([PATCH v3 7/7] spi: imx: defer spi > initialization, if DMA engine is pending). > > Regards, Anton Does anyone has other comments regarding this commit? Regards, Anton