Re: [PATCH] efinet: check for broken firmware

[Andrei Borzenkov <arvidjaar@gmail.com>]

14.11.2015 07:08, Josef Bacik пишет:
>
>> On Nov 13, 2015, at 10:19 PM, Andrei Borzenkov <arvidjaar@gmail.com> wrote:
>>
>> 13.11.2015 22:34, Josef Bacik пишет:
>>>> On 11/13/2015 09:38 AM, Vladimir 'phcoder' Serbinenko wrote:
>>>> Please try the patch currently used in Solaris flavour of GRUB. I think
>>>> of upstreaming their mnp driver
>>>
>>> This driver doesn't work at all for me.  I may have done a bad job
>>> porting it, or the firmware is even crappier with MNP, either way it's
>>> completely unusable.  I'll fix up this patch and send it along.  Thanks,
>>
>> So that I understand. You have a system where a) there is MNP Binding Protocol on network device and b) this does not work? Or your system does not offer MNP Binding Protocol for device?
>
> There is a MNP binding and the driver does not work. It sets everything up right but doesn't transmit or receive properly.
>

That's bad. It means even if we prefer MNP we still need to implement 
quirks to avoid it on known broken platforms.

> I figured out why my original approach wasn't working and why it works if I don't switch to exclusive.  I can now switch to exclusive and have things still working, just fixing up the patch now, I'll finish it on Monday and send it out.  Thanks,
>
> Josef
>