From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zxgox-0000pA-Qg for mharc-grub-devel@gnu.org; Sat, 14 Nov 2015 14:49:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxac5-00071V-R4 for grub-devel@gnu.org; Sat, 14 Nov 2015 08:11:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zxac0-0003iJ-R6 for grub-devel@gnu.org; Sat, 14 Nov 2015 08:11:29 -0500 Received: from mail-lf0-x22e.google.com ([2a00:1450:4010:c07::22e]:35433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxac0-0003iD-JR for grub-devel@gnu.org; Sat, 14 Nov 2015 08:11:24 -0500 Received: by lfdo63 with SMTP id o63so65906185lfd.2 for ; Sat, 14 Nov 2015 05:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=so9nea7EcLdoq7ee9aMbnIWl906eL/HFtUZwH6co8M8=; b=T1XkHVPAWmeImyIA2DVoRc/cyTav3ZJ00f6g3X96YGV4q5FW+s3mw0x+H45iLB4AL7 leBTlX7d8qDsxS3sd2bCox2IdDZAlCHsGlASnLeco7HIcjq3C5FNV6HHogOq5lgh1C/7 mnmBjjFIY5vZpIT7Y8hkIZU3LtHEZadcOt7OK+lwSNCwLUT4cD66qwnQb20ujHGt7RBT +EpP+VaCsEil/crOegOSY+4tMzsVv6F3JYTmWCIW26p7/3gVH6LQkpbS6iwCp8hu7FpT z8UhDZKCI84+yulUhEp02ga85ibw1XcrFHlvbPBDGgAbeuZfR7FUinFC/1iZXe9WDbGc u0uw== X-Received: by 10.25.87.71 with SMTP id l68mr12377920lfb.97.1447506683673; Sat, 14 Nov 2015 05:11:23 -0800 (PST) Received: from [192.168.1.41] (ppp91-76-25-247.pppoe.mtu-net.ru. [91.76.25.247]) by smtp.gmail.com with ESMTPSA id 64sm3986381lfu.35.2015.11.14.05.11.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Nov 2015 05:11:22 -0800 (PST) Subject: Re: [PATCH] efinet: check for broken firmware To: Josef Bacik References: <1447366056-3328165-1-git-send-email-jbacik@fb.com> <5645F3F9.7030405@fb.com> <56463B5E.7000600@fb.com> <5646A82F.3060503@gmail.com> From: Andrei Borzenkov Message-ID: <564732FA.5060200@gmail.com> Date: Sat, 14 Nov 2015 16:11:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::22e Cc: Vladimir 'phcoder' Serbinenko , Kernel Team , The development of GRUB 2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2015 13:11:30 -0000 14.11.2015 07:08, Josef Bacik пишет: > >> On Nov 13, 2015, at 10:19 PM, Andrei Borzenkov wrote: >> >> 13.11.2015 22:34, Josef Bacik пишет: >>>> On 11/13/2015 09:38 AM, Vladimir 'phcoder' Serbinenko wrote: >>>> Please try the patch currently used in Solaris flavour of GRUB. I think >>>> of upstreaming their mnp driver >>> >>> This driver doesn't work at all for me. I may have done a bad job >>> porting it, or the firmware is even crappier with MNP, either way it's >>> completely unusable. I'll fix up this patch and send it along. Thanks, >> >> So that I understand. You have a system where a) there is MNP Binding Protocol on network device and b) this does not work? Or your system does not offer MNP Binding Protocol for device? > > There is a MNP binding and the driver does not work. It sets everything up right but doesn't transmit or receive properly. > That's bad. It means even if we prefer MNP we still need to implement quirks to avoid it on known broken platforms. > I figured out why my original approach wasn't working and why it works if I don't switch to exclusive. I can now switch to exclusive and have things still working, just fixing up the patch now, I'll finish it on Monday and send it out. Thanks, > > Josef >