From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxea7-0007uw-0o for qemu-devel@nongnu.org; Sat, 14 Nov 2015 12:25:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zxea3-000163-JH for qemu-devel@nongnu.org; Sat, 14 Nov 2015 12:25:42 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:57508) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zxea3-00015T-9t for qemu-devel@nongnu.org; Sat, 14 Nov 2015 12:25:39 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 14 Nov 2015 17:25:36 -0000 Message-ID: <56476E85.4070406@fr.ibm.com> Date: Sat, 14 Nov 2015 18:25:25 +0100 From: =?windows-1252?Q?C=E9dric_Le_Goater?= MIME-Version: 1.0 References: <1447354953-18893-1-git-send-email-minyard@acm.org> In-Reply-To: <1447354953-18893-1-git-send-email-minyard@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 00/17] Add an IPMI device to QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, qemu-devel@nongnu.org, Paolo Bonzini , "Michael S. Tsirkin" , Igor Mammedov , "list@suse.de:PowerPC" On 11/12/2015 08:02 PM, minyard@acm.org wrote: > This is a long delayed patch set, but I think I have things reworked > to make Igor happy with the way ACPI and SMBIOS work. This is more > consistent with the way most other things work, anyway. It did > require adding stubs for systems without IPMI. > > The first nine patches are unchanged. > > The IPMI firmware configuration storage now holds the firmware information > in a data structure and lets it be iterated. > > SMBIOS and ACPI build the tables with their existing building > functions and call out to the IPMI one (or the stub) when the time > comes. This required pulling some code out of smbios.c into an > include file and making some things global, as IPMI has to be > configurable. > > The BIOS table tests were also modified since the ACPI info is > now in the existing SSDT. > > I've also added a force-off function for external BMCs; an external > BMC needs a way to do a hard power-off of the system if the soft > power offs fail. > > Thanks all! > > -corey Hi Corey, Adding your patchset to Ben's work on the PowerNV platform gives us a promising OpenPower system simulator ! I did not have to do too much to make it work. A few SENSOR_EVENT commands are missing which Openpower systems use. I did the merge and quick addons here : https://github.com/legoater/qemu/tree/powernv-ipmi For a first try, that went extremely well. The system boots and the ipmi device is fully functionnal. I guess we would need to define a larger set of sdrs. They can be added to the bmc simulator device probably with time. OpenPower systems also use some specific OEM event upon reboot and reset when initiated from the bmc. We need will to find a way to fill the event buffer with such data. Nothing complex. I was wondering how much fix up we should be doing in the firmware (skiboot) when running a qemu guest. I guess we should try to generate as much we can of the device tree in qemu depending on the devices available ? or shall we force the qemu platform in skiboot to be strictly openpower oriented ? Thanks, C.