All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Sean Nyekjaer <sean.nyekjaer@prevas.dk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH v3] iio: core: added support for IIO_VAL_INT
Date: Sun, 15 Nov 2015 10:54:16 +0000	[thread overview]
Message-ID: <56486458.4000801@kernel.org> (raw)
In-Reply-To: <1447073734-18602-1-git-send-email-sean.nyekjaer@prevas.dk>

On 09/11/15 12:55, Sean Nyekjaer wrote:
> Added core support for IIO_VAL_INT in write_raw_get_fmt function.
> 
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to try and break it.

Thanks for sorting this out!

Jonathan
> ---
> Sorry for v1, i've missed the "too many 'd's" comment
> 
> Changes since v2:
>  - Fixed commit msg
> 
> Changes since v1:
>  - fract_mult set to 0
>  - iio_str_to_fixpoint uses kstrtoint for fract_mult = 0
> 
>  drivers/iio/industrialio-core.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 208358f..d0a84fe 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -512,6 +512,12 @@ int iio_str_to_fixpoint(const char *str, int fract_mult,
>  	int i = 0, f = 0;
>  	bool integer_part = true, negative = false;
>  
> +	if (fract_mult == 0) {
> +		*fract = 0;
> +
> +		return kstrtoint(str, 0, integer);
> +	}
> +
>  	if (str[0] == '-') {
>  		negative = true;
>  		str++;
> @@ -571,6 +577,9 @@ static ssize_t iio_write_channel_info(struct device *dev,
>  	if (indio_dev->info->write_raw_get_fmt)
>  		switch (indio_dev->info->write_raw_get_fmt(indio_dev,
>  			this_attr->c, this_attr->address)) {
> +		case IIO_VAL_INT:
> +			fract_mult = 0;
> +			break;
>  		case IIO_VAL_INT_PLUS_MICRO:
>  			fract_mult = 100000;
>  			break;
> 


      reply	other threads:[~2015-11-15 10:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 12:55 [PATCH v3] iio: core: added support for IIO_VAL_INT Sean Nyekjaer
2015-11-15 10:54 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56486458.4000801@kernel.org \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=sean.nyekjaer@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.