All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@scylladb.com>
To: xfs@oss.sgi.com, linux-aio@kvack.org
Subject: AIO read returns negative number for bytes read
Date: Sun, 15 Nov 2015 15:08:13 +0200	[thread overview]
Message-ID: <564883BD.8070607@scylladb.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Due to a bug in my program, I initiated a read beyond eof. Specifically, 
the file size is 13002 bytes and the read offset is 13312 (0x3400).

I would expect such a read to return 0 bytes read, but io_getevents 
returns -310, which is suspiciously equal to (13002 - 13312).

I attach a reproducer.

4.2.5-201.fc22.x86_64

Are my expectations incorrect, or is this a bug in aio or xfs?

[-- Attachment #2: aio_read_fails.c --]
[-- Type: text/plain, Size: 966 bytes --]

#define _GNU_SOURCE

#include <libaio.h>
#include <assert.h>
#include <stdlib.h>
#include <sys/types.h>
#include <unistd.h>
#include <stdio.h>
#include <sys/stat.h>
#include <fcntl.h>

int main(int ac, char** av) {
  int fd;
  char* buf;
  io_context_t ioc = NULL;
  int r;
  struct iocb iocb;
  struct iocb *iocbp[1];
  struct io_event ioev;

  buf = aligned_alloc(4096, 4096*4);
  assert(buf);
  r = io_setup(1, &ioc);
  assert(r == 0);
  fd = open("tmp.tmp", O_RDWR | O_CREAT | O_DIRECT, 0600);
  assert(fd >= 0);
  io_prep_pwrite(&iocb, fd, buf, 4096*4, 0);
  iocbp[0] = &iocb;
  r = io_submit(ioc, 1, iocbp);
  assert(r == 1);
  r = io_getevents(ioc, 1, 1, &ioev, NULL);
  assert(r == 1);
  assert(ioev.res == 4*4096);
  ftruncate(fd, 13002);
  io_prep_pread(&iocb, fd, buf, 8192, 13312);
  r = io_submit(ioc, 1, iocbp);
  assert(r == 1);
  r = io_getevents(ioc, 1, 1, &ioev, NULL);
  assert(r == 1);
  printf("read result: %d\n", (int)ioev.res);
  return 0;
}

[-- Attachment #3: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2015-11-15 13:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-15 13:08 Avi Kivity [this message]
2015-11-16 15:00 ` AIO read returns negative number for bytes read Brian Foster
2015-11-16 15:19 ` Alireza Haghdoost
2015-11-16 15:32   ` Avi Kivity
2015-11-16 19:27 ` Jeff Moyer
2015-11-16 19:27   ` Jeff Moyer
2015-11-17 12:52   ` Avi Kivity
2015-11-17 12:52     ` Avi Kivity
2015-11-19 15:30     ` Jan Kara
2015-11-19 15:30       ` Jan Kara
2015-11-19 15:32       ` Avi Kivity
2015-11-19 15:32         ` Avi Kivity
2015-11-19 15:33       ` Jeff Moyer
2015-11-19 15:33         ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564883BD.8070607@scylladb.com \
    --to=avi@scylladb.com \
    --cc=linux-aio@kvack.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.