From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Message-id: <564947E1.1030409@samsung.com> Date: Mon, 16 Nov 2015 12:05:05 +0900 From: Chanwoo Choi To: Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Kukjin Kim , Olof Johansson , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Kevin Hilman Cc: Pankaj Dubey Subject: Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 References: <1447637775-9887-1-git-send-email-k.kozlowski@samsung.com> <1447637775-9887-2-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1447637775-9887-2-git-send-email-k.kozlowski@samsung.com> List-ID: Hi, On 2015=EB=85=84 11=EC=9B=94 16=EC=9D=BC 10:36, Krzysztof Kozlowski wrote: > Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXYNOS > so it is built also on ARMv7. This does not bring any kind of benefit. > There won't be a single kernel image for ARMv7 and ARMv8 SoCs (like > multi_v7 for ARMv7). > > Instead build clock drivers only for respective SoC's architecture. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/samsung/Kconfig | 13 +++++++++++++ > drivers/clk/samsung/Makefile | 4 ++-- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig > index 84196ecdaa12..5f138fc4d84d 100644 > --- a/drivers/clk/samsung/Kconfig > +++ b/drivers/clk/samsung/Kconfig > @@ -2,6 +2,7 @@ config COMMON_CLK_SAMSUNG > bool > select COMMON_CLK > > +# ARMv7 SoCs: > config S3C2410_COMMON_CLK > bool > select COMMON_CLK_SAMSUNG > @@ -24,3 +25,15 @@ config S3C2443_COMMON_CLK > bool > select COMMON_CLK_SAMSUNG > > +# ARMv8 SoCs: > +config EXYNOS5433_COMMON_CLK > + bool > + depends on ARM64 || COMPILE_TEST > + default ARCH_EXYNOS > + select COMMON_CLK_SAMSUNG > + > +config EXYNOS7_COMMON_CLK > + bool > + depends on ARM64 || COMPILE_TEST > + default ARCH_EXYNOS > + select COMMON_CLK_SAMSUNG > diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile > index 5f6833ea355d..a31332a24ef4 100644 > --- a/drivers/clk/samsung/Makefile > +++ b/drivers/clk/samsung/Makefile > @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) +=3D clk-exynos5250.o > obj-$(CONFIG_SOC_EXYNOS5260) +=3D clk-exynos5260.o > obj-$(CONFIG_SOC_EXYNOS5410) +=3D clk-exynos5410.o > obj-$(CONFIG_SOC_EXYNOS5420) +=3D clk-exynos5420.o > -obj-$(CONFIG_ARCH_EXYNOS) +=3D clk-exynos5433.o > +obj-$(CONFIG_EXYNOS5433_COMMON_CLK) +=3D clk-exynos5433.o > obj-$(CONFIG_SOC_EXYNOS5440) +=3D clk-exynos5440.o > obj-$(CONFIG_ARCH_EXYNOS) +=3D clk-exynos-audss.o > obj-$(CONFIG_ARCH_EXYNOS) +=3D clk-exynos-clkout.o > -obj-$(CONFIG_ARCH_EXYNOS7) +=3D clk-exynos7.o > +obj-$(CONFIG_EXYNOS7_COMMON_CLK) +=3D clk-exynos7.o > obj-$(CONFIG_S3C2410_COMMON_CLK)+=3D clk-s3c2410.o > obj-$(CONFIG_S3C2410_COMMON_DCLK)+=3D clk-s3c2410-dclk.o > obj-$(CONFIG_S3C2412_COMMON_CLK)+=3D clk-s3c2412.o > Looks good to me. Reviewed-by: Chanwoo Choi Regards, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Date: Mon, 16 Nov 2015 12:05:05 +0900 Message-ID: <564947E1.1030409@samsung.com> References: <1447637775-9887-1-git-send-email-k.kozlowski@samsung.com> <1447637775-9887-2-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <1447637775-9887-2-git-send-email-k.kozlowski@samsung.com> Sender: linux-clk-owner@vger.kernel.org To: Krzysztof Kozlowski , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Kukjin Kim , Olof Johansson , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Kevin Hilman Cc: Pankaj Dubey List-Id: linux-samsung-soc@vger.kernel.org Hi, On 2015=EB=85=84 11=EC=9B=94 16=EC=9D=BC 10:36, Krzysztof Kozlowski wro= te: > Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXY= NOS > so it is built also on ARMv7. This does not bring any kind of benefit= =2E > There won't be a single kernel image for ARMv7 and ARMv8 SoCs (like > multi_v7 for ARMv7). >=20 > Instead build clock drivers only for respective SoC's architecture. >=20 > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/samsung/Kconfig | 13 +++++++++++++ > drivers/clk/samsung/Makefile | 4 ++-- > 2 files changed, 15 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfi= g > index 84196ecdaa12..5f138fc4d84d 100644 > --- a/drivers/clk/samsung/Kconfig > +++ b/drivers/clk/samsung/Kconfig > @@ -2,6 +2,7 @@ config COMMON_CLK_SAMSUNG > bool > select COMMON_CLK > =20 > +# ARMv7 SoCs: > config S3C2410_COMMON_CLK > bool > select COMMON_CLK_SAMSUNG > @@ -24,3 +25,15 @@ config S3C2443_COMMON_CLK > bool > select COMMON_CLK_SAMSUNG > =20 > +# ARMv8 SoCs: > +config EXYNOS5433_COMMON_CLK > + bool > + depends on ARM64 || COMPILE_TEST > + default ARCH_EXYNOS > + select COMMON_CLK_SAMSUNG > + > +config EXYNOS7_COMMON_CLK > + bool > + depends on ARM64 || COMPILE_TEST > + default ARCH_EXYNOS > + select COMMON_CLK_SAMSUNG > diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makef= ile > index 5f6833ea355d..a31332a24ef4 100644 > --- a/drivers/clk/samsung/Makefile > +++ b/drivers/clk/samsung/Makefile > @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) +=3D clk-exynos5250.= o > obj-$(CONFIG_SOC_EXYNOS5260) +=3D clk-exynos5260.o > obj-$(CONFIG_SOC_EXYNOS5410) +=3D clk-exynos5410.o > obj-$(CONFIG_SOC_EXYNOS5420) +=3D clk-exynos5420.o > -obj-$(CONFIG_ARCH_EXYNOS) +=3D clk-exynos5433.o > +obj-$(CONFIG_EXYNOS5433_COMMON_CLK) +=3D clk-exynos5433.o > obj-$(CONFIG_SOC_EXYNOS5440) +=3D clk-exynos5440.o > obj-$(CONFIG_ARCH_EXYNOS) +=3D clk-exynos-audss.o > obj-$(CONFIG_ARCH_EXYNOS) +=3D clk-exynos-clkout.o > -obj-$(CONFIG_ARCH_EXYNOS7) +=3D clk-exynos7.o > +obj-$(CONFIG_EXYNOS7_COMMON_CLK) +=3D clk-exynos7.o > obj-$(CONFIG_S3C2410_COMMON_CLK)+=3D clk-s3c2410.o > obj-$(CONFIG_S3C2410_COMMON_DCLK)+=3D clk-s3c2410-dclk.o > obj-$(CONFIG_S3C2412_COMMON_CLK)+=3D clk-s3c2412.o >=20 Looks good to me. Reviewed-by: Chanwoo Choi Regards, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Mon, 16 Nov 2015 12:05:05 +0900 Subject: [PATCH 1/2] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 In-Reply-To: <1447637775-9887-2-git-send-email-k.kozlowski@samsung.com> References: <1447637775-9887-1-git-send-email-k.kozlowski@samsung.com> <1447637775-9887-2-git-send-email-k.kozlowski@samsung.com> Message-ID: <564947E1.1030409@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 2015? 11? 16? 10:36, Krzysztof Kozlowski wrote: > Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXYNOS > so it is built also on ARMv7. This does not bring any kind of benefit. > There won't be a single kernel image for ARMv7 and ARMv8 SoCs (like > multi_v7 for ARMv7). > > Instead build clock drivers only for respective SoC's architecture. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/clk/samsung/Kconfig | 13 +++++++++++++ > drivers/clk/samsung/Makefile | 4 ++-- > 2 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig > index 84196ecdaa12..5f138fc4d84d 100644 > --- a/drivers/clk/samsung/Kconfig > +++ b/drivers/clk/samsung/Kconfig > @@ -2,6 +2,7 @@ config COMMON_CLK_SAMSUNG > bool > select COMMON_CLK > > +# ARMv7 SoCs: > config S3C2410_COMMON_CLK > bool > select COMMON_CLK_SAMSUNG > @@ -24,3 +25,15 @@ config S3C2443_COMMON_CLK > bool > select COMMON_CLK_SAMSUNG > > +# ARMv8 SoCs: > +config EXYNOS5433_COMMON_CLK > + bool > + depends on ARM64 || COMPILE_TEST > + default ARCH_EXYNOS > + select COMMON_CLK_SAMSUNG > + > +config EXYNOS7_COMMON_CLK > + bool > + depends on ARM64 || COMPILE_TEST > + default ARCH_EXYNOS > + select COMMON_CLK_SAMSUNG > diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile > index 5f6833ea355d..a31332a24ef4 100644 > --- a/drivers/clk/samsung/Makefile > +++ b/drivers/clk/samsung/Makefile > @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o > obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o > obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o > obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o > -obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o > +obj-$(CONFIG_EXYNOS5433_COMMON_CLK) += clk-exynos5433.o > obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o > obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o > obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o > -obj-$(CONFIG_ARCH_EXYNOS7) += clk-exynos7.o > +obj-$(CONFIG_EXYNOS7_COMMON_CLK) += clk-exynos7.o > obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o > obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o > obj-$(CONFIG_S3C2412_COMMON_CLK)+= clk-s3c2412.o > Looks good to me. Reviewed-by: Chanwoo Choi Regards, Chanwoo Choi