All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gauche: fix getcontext not solved error on link
Date: Mon, 16 Nov 2015 08:00:53 +0100	[thread overview]
Message-ID: <56497F25.4020100@mind.be> (raw)
In-Reply-To: <201511131005.tADA5pt9030611@ms-omx02.plus.so-net.ne.jp>

On 13-11-15 11:05, Hiroshi Kawashima wrote:
> This patch is ported from bdwgc package.
> Gauche use internal boehm gc so it has same problem.
> 
> I touch configure directly instead of configure.ac because autoreconf
> failed by version mismatch of autotools.
> 
> Will fix:
> http://autobuild.buildroot.org/results/8c6/8c6ce526735a36b8c8b4c6047e3c69039c4527cb//
> http://autobuild.buildroot.org/results/894/89460829a737a4dab19103f7a46905636420b0a8//
> 
> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 However, ideally you should patch both configure.ac and configure, and also
send the patch upstream of course.

 Regards,
 Arnout

> ---
>  ...ac-add-check-for-NO_GETCONTEXT-definition.patch |   61 ++++++++++++++++++++
>  1 files changed, 61 insertions(+), 0 deletions(-)
>  create mode 100644 package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch
> 
> diff --git a/package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch b/package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch
> new file mode 100644
> index 0000000..8940574
> --- /dev/null
> +++ b/package/gauche/0002-gc-configure.ac-add-check-for-NO_GETCONTEXT-definition.patch
> @@ -0,0 +1,61 @@
> +gc/configure.ac: add check for NO_GETCONTEXT definition
> +
> +This patch is ported from bdwgc package.
> +Gauche use internal boehm gc so it has same problem.
> +
> +I touch configure directly instead of configure.ac because autoreconf
> +failed by version mismatch of autotools.
> +
> +Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
> +
> +Original credits of patch in bdwgc package:
> +Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> +[yann.morin.1998 at free.fr: add a comment, change variable name, use
> + AS_IF, remove debug traces, use AC_CHECK_FUNCS (as suggested by
> + Thomas)]
> +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> +Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> +
> +diff -ur a/gc/configure b/gc/configure
> +--- a/gc/configure	2015-11-12 21:41:02.394822056 +0900
> ++++ b/gc/configure	2015-11-12 22:04:14.655157423 +0900
> +@@ -16153,6 +16153,23 @@
> + $as_echo "$ac_cv_fno_strict_aliasing" >&6; }
> + fi
> + 
> ++# Check for getcontext (uClibc can be configured without it, for example)
> ++for ac_func in getcontext
> ++do :
> ++  ac_fn_c_check_func "$LINENO" "getcontext" "ac_cv_func_getcontext"
> ++if test "x$ac_cv_func_getcontext" = xyes; then :
> ++  cat >>confdefs.h <<_ACEOF
> ++#define HAVE_GETCONTEXT 1
> ++_ACEOF
> ++
> ++fi
> ++done
> ++
> ++if test "$ac_cv_func_getcontext" = "no"; then :
> ++  CFLAGS="$CFLAGS -DNO_GETCONTEXT"
> ++   CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"
> ++fi
> ++
> + case "$host" in
> + # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64
> + # and unnecessary everywhere.
> +diff -ur a/gc/configure.ac b/gc/configure.ac
> +--- a/gc/configure.ac	2015-11-12 22:31:44.851510997 +0900
> ++++ b/gc/configure.ac	2015-11-12 22:33:39.292191227 +0900
> +@@ -459,6 +459,12 @@
> +   AC_MSG_RESULT($ac_cv_fno_strict_aliasing)
> + fi
> + 
> ++# Check for getcontext (uClibc can be configured without it, for example)
> ++AC_CHECK_FUNCS([getcontext])
> ++AS_IF([test "$ac_cv_func_getcontext" = "no"],
> ++  [CFLAGS="$CFLAGS -DNO_GETCONTEXT"
> ++   CPPFLAGS="$CPPFLAGS -DNO_GETCONTEXT"])
> ++
> + case "$host" in
> + # While IRIX 6 has libdl for the O32 and N32 ABIs, it's missing for N64
> + # and unnecessary everywhere.
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-11-16  7:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 10:05 [Buildroot] [PATCH] package/gauche: fix getcontext not solved error on link Hiroshi Kawashima
2015-11-16  7:00 ` Arnout Vandecappelle [this message]
2015-11-16 12:33   ` Hiroshi Kawashima
2015-11-16 14:04     ` Arnout Vandecappelle
2015-11-16 22:03 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56497F25.4020100@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.