From: Mark Lord <kernel@start.ca>
To: vinayak.kale@gmail.com, tj@kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: sumit.g.gupta@seagate.com, Vinayak Kale <vinayak.kale@seagate.com>
Subject: Re: [PATCH v2] libata: add support for NCQ commands for SG interface
Date: Mon, 16 Nov 2015 08:47:19 -0500 [thread overview]
Message-ID: <5649DE67.7080509@start.ca> (raw)
In-Reply-To: <1445924955-11124-1-git-send-email-vinayak.kale@seagate.com>
On 15-10-27 01:49 AM, vinayak.kale@gmail.com wrote:
> From: Vinayak Kale <vinayak.kale@seagate.com>
>
> This patch is needed to make NCQ commands with FPDMA protocol value
> (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface.
..
> + /* For NCQ commands with FPDMA protocol, copy the tag value */
> + if (tf->protocol == ATA_PROT_NCQ)
> + tf->nsect = qc->tag << 3;
> +
What prevents the qc-tag value here from conflicting with in-flight I/O
using the exact same qc-tag ??
next prev parent reply other threads:[~2015-11-16 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 5:49 [PATCH v2] libata: add support for NCQ commands for SG interface vinayak.kale
2015-10-27 6:16 ` Tejun Heo
2015-10-27 6:37 ` Vinayak Kale
2015-11-16 13:47 ` Mark Lord [this message]
2015-11-16 15:31 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5649DE67.7080509@start.ca \
--to=kernel@start.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.g.gupta@seagate.com \
--cc=tj@kernel.org \
--cc=vinayak.kale@gmail.com \
--cc=vinayak.kale@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.