From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZyQVJ-0002Wj-9p for mharc-grub-devel@gnu.org; Mon, 16 Nov 2015 15:35:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyLvd-0001oC-3M for grub-devel@gnu.org; Mon, 16 Nov 2015 10:42:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyLvZ-00056t-2K for grub-devel@gnu.org; Mon, 16 Nov 2015 10:42:49 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:40325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyLvY-00056p-Q9 for grub-devel@gnu.org; Mon, 16 Nov 2015 10:42:44 -0500 Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id tAGFdkoB010118; Mon, 16 Nov 2015 07:42:41 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=subject : to : references : cc : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=UR8ZaPUJZoZzdXgPGPU2e6PA6VLcvnx0AjqXurWShv8=; b=lacPXpO8hBBQ1buTPpSeprfDXQUcEoKMZqCmOUNOuAfH4WCsl7+mLv6Mb4b8qxPhz0qo e7HYTdiZnKf7Y5sO3oMdaPpkt92jtODCj2nhkX/YlUx5pKlTRKi6YGbKGMWqZXuGrMDh zRVvCTt3gwzNJ1oroaFlvQvoxeYizusR/gc= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 1y6156xted-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Mon, 16 Nov 2015 07:42:41 -0800 Received: from localhost.localdomain (192.168.52.123) by mail.thefacebook.com (192.168.16.14) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 16 Nov 2015 07:42:38 -0800 Subject: Re: [PATCH] efinet: check for broken firmware To: "Vladimir 'phcoder' Serbinenko" References: <1447366056-3328165-1-git-send-email-jbacik@fb.com> <5645F3F9.7030405@fb.com> <56463B5E.7000600@fb.com> <5646A82F.3060503@gmail.com> From: Josef Bacik Message-ID: <5649F96C.4090206@fb.com> Date: Mon, 16 Nov 2015 10:42:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2015-11-16_12:, , signatures=0 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-00082601.pphosted.com id tAGFdkoB010118 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 67.231.145.42 Cc: Andrey Borzenkov , The development of GRUB 2 , kernel-team@fb.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2015 15:42:50 -0000 On 11/14/2015 09:13 AM, Vladimir 'phcoder' Serbinenko wrote: > Le 14 nov. 2015 5:08 AM, "Josef Bacik" > a =C3=A9crit : > > > > > > > > > > On Nov 13, 2015, at 10:19 PM, Andrei Borzenkov > wrote: > > > > > > > > 13.11.2015 22:34, Josef Bacik =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > >>> On 11/13/2015 09:38 AM, Vladimir 'phcoder' Serbinenko wrote: > > > >>> Please try the patch currently used in Solaris flavour of GRUB. = I > think > > > >>> of upstreaming their mnp driver > > > >> > > > >> This driver doesn't work at all for me. I may have done a bad jo= b > > > >> porting it, or the firmware is even crappier with MNP, either way= it's > > > >> completely unusable. I'll fix up this patch and send it along. > Thanks, > > > > > > > > So that I understand. You have a system where a) there is MNP > Binding Protocol on network device and b) this does not work? Or your > system does not offer MNP Binding Protocol for device? > > > > > > There is a MNP binding and the driver does not work. It sets > everything up right but doesn't transmit or receive properly. > > > > > Are you sure that the driver itself works? Could you have introduced > bugs when adapting it? > I could have, the only thing I had to do was add the definitions for the=20 efi api's that we are missing, so the trigger stuff basically. It was=20 just copy and pasting, it's not like I changed any functionality, I=20 didn't touch the driver at all. Their grub2 version seems to be a=20 little older. If somebody gets a driver into the git tree then I'll=20 happily test it, but this port definitely didn't work and I have little=20 interest in trying to adapt somebody else's code and trying to debug it.=20 Thanks, Josef