From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
linux-kernel@vger.kernel.org, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs
Date: Mon, 16 Nov 2015 16:46:26 -0500 [thread overview]
Message-ID: <564A4EB2.6050401@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1511162229520.3761@nanos>
On 11/16/2015 04:39 PM, Thomas Gleixner wrote:
> On Mon, 16 Nov 2015, Boris Ostrovsky wrote:
>> Xen expects legacy interrupts to be there (pretty much for the same reason as
>> Hyper-V does) and with this change arch_probe_nr_irqs() returns zero and no
>> descriptors are allocated.
> Right, because everything which has a PIT gets them and everything
> which does not have a PIT does not.
>
>> We can allocate those descriptors as needed in xen_irq_init() (if we know that
>> IRQs are legacy), although that would look somewhat ugly and out of place.
> Why preallocating them in xen_irq_init()? You simply can remove the
> NR_IRQS_LEGACY checks in xen_allocate_irq_gsi/xen_free_irq(), right?
Of course. Thanks.
-boris
next prev parent reply other threads:[~2015-11-16 21:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 9:40 [PATCH v2] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs Vitaly Kuznetsov
2015-11-04 10:52 ` [tip:x86/urgent] " tip-bot for Vitaly Kuznetsov
2015-11-07 9:43 ` tip-bot for Vitaly Kuznetsov
2015-11-16 21:00 ` [PATCH v2] " Boris Ostrovsky
2015-11-16 21:00 ` Boris Ostrovsky
2015-11-16 21:39 ` Thomas Gleixner
2015-11-16 21:39 ` Thomas Gleixner
2015-11-16 21:46 ` Boris Ostrovsky [this message]
2015-11-16 21:46 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564A4EB2.6050401@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=jiang.liu@linux.intel.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.