From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyWOR-0001Tf-Vo for qemu-devel@nongnu.org; Mon, 16 Nov 2015 21:53:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyWOO-0004nG-PV for qemu-devel@nongnu.org; Mon, 16 Nov 2015 21:53:15 -0500 Received: from [59.151.112.132] (port=64108 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyWOO-0004l6-Cg for qemu-devel@nongnu.org; Mon, 16 Nov 2015 21:53:12 -0500 Message-ID: <564A9571.3060304@cn.fujitsu.com> Date: Tue, 17 Nov 2015 10:48:17 +0800 From: Chen Fan MIME-Version: 1.0 References: <7e222e2840fe58fe26d3bd73f626c1da029ca981.1447231392.git.chen.fan.fnst@cn.fujitsu.com> <20151112134713-mutt-send-email-mst@redhat.com> <564558CA.6030102@cn.fujitsu.com> <1447448661.3946.147.camel@redhat.com> <5649AD5F.6020407@cn.fujitsu.com> <1447689937.3946.243.camel@redhat.com> In-Reply-To: <1447689937.3946.243.camel@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v13 09/13] add check reset mechanism when hotplug vfio device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: Cao jin , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 11/17/2015 12:05 AM, Alex Williamson wrote: > On Mon, 2015-11-16 at 18:18 +0800, Chen Fan wrote: >> Hi Alex, >> >> Thanks for your detailed explanation. >> during my test, I found that maybe there was another problem in vfio >> driver, >> I use a dual-port NIC which address are: 06:00.0 and 06:00.1 two functions. >> then I use aer-inject to inject one error to one function like following: >> AER >> ID 0000:06:00.0 >> UNCOR_STATUS DLP >> HEADER_LOG 0 1 2 3 >> >> here I boot qemu with one enable aer, one disable aer: >> ./x86_64-softmmu/qemu-system-x86_64 -M q35 -device >> ioh3420,bus=pcie.0,addr=1c.0,port=1,id=bridge1,chassis=1 >> -device vfio-pci,host=06:00.1,bus=bridge1,addr=00.1 >> -device >> vfio-pci,host=06:00.0,bus=bridge1,addr=00.0,aer=true,multifunction=on >> >> so we expected that the error only sent to the vfio device with host >> address is 06:00.0, >> but I found that all devices (06:00.0 , 06:00.1) receive the signal in >> qemu, which sent by vfio driver >> in vfio_pci_aer_err_detected. then qemu stopped by the device with >> 06:00.1 received the signal. >> is that right? > You would need to know whether the response for the injected AER affects > all devices on the link or is isolated to the function specified. VFIO > is just a passthrough for pci_error_handlers, so if error_detected is > getting called for each host device, it's going to signal each device to > the user. Thanks, I saw that in broadcast error message, if the error is reported by an end point, aer driver would broadcast the error to all functions under the upstream link of the end point. so here in qemu, I think we should enable AER for all functions in one endpoint. Thanks, Chen > Alex > > . >