All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michel Dänzer" <michel@daenzer.net>
To: Emil Velikov <emil.l.velikov@gmail.com>,
	Gabriel Laskar <gabriel@lse.epita.fr>
Cc: Mikko Rapeli <mikko.rapeli@iki.fi>,
	DRI devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 0/9] uapi: drm: fixes for userspace compilation
Date: Tue, 17 Nov 2015 16:22:50 +0900	[thread overview]
Message-ID: <564AD5CA.7080207@daenzer.net> (raw)
In-Reply-To: <CACvgo524CWSrOBF8VovY6y2pwn3iq4Xv5QvYAzazbiDyKj+g=Q@mail.gmail.com>

On 14.11.2015 07:06, Emil Velikov wrote:
> On 13 November 2015 at 21:36, Gabriel Laskar <gabriel@lse.epita.fr> wrote:
>>
>> There is still some issues on the headers, like the inclusion of drm.h.
>>
>> AFAIK, we should include "drm.h", in order to minimize the changes
>> between linux/libdrm when importing, as the folders are not always the
>> same (on Archlinux for example, drm.h is installed
>> in /usr/include/libdrm/drm.h). This is not always the case in some of
>> the headers:
>>
> I'm afraid we cannot do this. Things should just work without the
> extra include directive (from your earlier example). We can easily fix
> this and other issues in an automated way during import.

[...]

>> I can send patches for them too, I just need to know if this is useful,
>> and not just nitpicking for you.
>>
> Everything but the s|drm/drm.h|drm.h| suggestion is pretty valid imho.

What's the problem with changing

#include <drm/drm.h>

to

#include "drm.h"

in include/uapi/drm/*_drm.h? I recently made that change in radeon_drm.h
and amdgpu_drm.h for the reason Gabriel mentioned above (in particular
amdgpu_drm.h is now basically identical between the kernel and libdrm
trees), and I haven't noticed any problems because of that.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-11-17  7:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 18:14 [PATCH 0/9] uapi: drm: fixes for userspace compilation Gabriel Laskar
2015-11-12 18:14 ` [PATCH 1/9] include/uapi/drm/armada_drm.h: use __u{32,64} types instead of uint{32,64}_t Gabriel Laskar
2015-11-12 18:14   ` Gabriel Laskar
2015-11-12 18:14 ` [PATCH 2/9] include/uapi/drm/virtgpu_drm.h: " Gabriel Laskar
2015-11-12 18:14   ` Gabriel Laskar
2015-11-12 18:14 ` [PATCH 3/9] include/uapi/drm/qxl_drm.h: " Gabriel Laskar
2015-11-12 18:14   ` Gabriel Laskar
2015-11-12 18:14 ` [PATCH 4/9] include/uapi/drm/nouveau_drm.h: " Gabriel Laskar
2015-11-12 18:14   ` Gabriel Laskar
2015-11-12 18:14 ` [PATCH 5/9] include/uapi/drm/amdgpu_drm.h: " Gabriel Laskar
2015-11-12 18:14   ` Gabriel Laskar
2015-11-12 18:14 ` [PATCH 6/9] include/uapi/drm/armada_drm.h: " Gabriel Laskar
2015-11-12 18:14   ` Gabriel Laskar
2015-11-12 18:14 ` [PATCH 7/9] include/uapi/drm/drm_mode.h: " Gabriel Laskar
2015-11-12 18:14   ` Gabriel Laskar
2015-11-12 18:14 ` [PATCH 8/9] include/uapi/drm/vmwgfx_drm.h: " Gabriel Laskar
2015-11-12 18:14   ` Gabriel Laskar
2015-11-12 18:14 ` [PATCH 9/9] include/uapi/drm/omap_drm.h: " Gabriel Laskar
2015-11-12 18:14   ` Gabriel Laskar
2015-11-12 19:34 ` [PATCH 0/9] uapi: drm: fixes for userspace compilation Emil Velikov
2015-11-13 19:24   ` Gabriel Laskar
2015-11-13 19:31     ` Gabriel Laskar
2015-11-13 20:38       ` Emil Velikov
2015-11-13 21:36         ` Gabriel Laskar
2015-11-13 22:06           ` Emil Velikov
2015-11-17  7:22             ` Michel Dänzer [this message]
2015-11-17 11:08               ` Emil Velikov
2015-11-17 19:13                 ` Gabriel Laskar
2015-11-17 21:22                   ` Emil Velikov
2015-11-18  3:12                     ` Michel Dänzer
2015-11-18 12:54                       ` Emil Velikov
2015-11-17 20:13                 ` Dave Airlie
2015-11-17 22:00                   ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564AD5CA.7080207@daenzer.net \
    --to=michel@daenzer.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=gabriel@lse.epita.fr \
    --cc=mikko.rapeli@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.