Re: [PATCH for-next 03/10] IB/iser: Don't register memory for all immediatedata writes

[Or Gerlitz <ogerlitz@mellanox.com>]

On 11/16/2015 6:37 PM, Sagi Grimberg wrote:
> --- a/drivers/infiniband/ulp/iser/iser_memory.c
> +++ b/drivers/infiniband/ulp/iser/iser_memory.c
> @@ -250,7 +250,7 @@ iser_reg_dma(struct iser_device *device, struct iser_data_buf *mem,
>   	struct scatterlist *sg = mem->sg;
>   
>   	reg->sge.lkey = device->pd->local_dma_lkey;
> -	reg->rkey = device->mr->rkey;
> +	reg->rkey = device->mr ? device->mr->rkey : 0;
>   	reg->sge.addr = ib_sg_dma_address(device->ib_device, &sg[0]);
>   	reg->sge.length = ib_sg_dma_len(device->ib_device, &sg[0]);
>   

what's the role of this hunk? why it belongs here? you are testing 
device->mr but this is
something global and has nothing to do specially with specific IOs for 
which this patch
aims to act