From: "Simon Kågström" <simon.kagstrom@netinsight.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH] rte_sched: release enqueued mbufs on rte_sched_port_free()
Date: Tue, 17 Nov 2015 08:53:17 +0100 [thread overview]
Message-ID: <564ADCED.2050100@netinsight.net> (raw)
In-Reply-To: <20151104101426.2f771b45@xeon-e3>
On 2015-11-04 19:14, Stephen Hemminger wrote:
> On Wed, 28 Oct 2015 10:56:33 +0100
> Simon Kagstrom <simon.kagstrom@netinsight.net> wrote:
>
>> Otherwise mbufs will leak when the port is destroyed. The
>> rte_sched_port_qbase() and rte_sched_port_qsize() functions are used
>> in free now, so move them up.
>>
>> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
>
> Overall it looks good, and fixes a long standing bug.
> Maybe good to expose it as a API function rte_sched_port_flush
> to allow use from applications.
I'm sorry, I missed this reply! I will fix the issues you point to and
repost.
// Simon
prev parent reply other threads:[~2015-11-17 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 9:56 [PATCH] rte_sched: release enqueued mbufs on rte_sched_port_free() Simon Kagstrom
2015-11-04 7:49 ` Simon Kågström
2015-11-04 18:14 ` Stephen Hemminger
2015-11-17 7:53 ` Simon Kågström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564ADCED.2050100@netinsight.net \
--to=simon.kagstrom@netinsight.net \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.