All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Sledz <sledz@dresearch-fe.de>
To: openembedded-devel <openembedded-devel@lists.openembedded.org>,
	Kang Kai <kai.kang@windriver.com>,
	Martin Jansa <Martin.Jansa@gmail.com>,
	Chen Qi <Qi.Chen@windriver.com>,
	Ross Burton <ross.burton@intel.com>,
	Armin Kuster <akuster808@gmail.com>
Subject: Re: rsyslog: buggy systemd/ua handling?
Date: Tue, 17 Nov 2015 09:08:33 +0100	[thread overview]
Message-ID: <564AE081.30004@dresearch-fe.de> (raw)
In-Reply-To: <5649BDDE.6030107@dresearch-fe.de>

On 16.11.2015 12:28, Steffen Sledz wrote:
> I'm not sure but i believe there's a bug in the systemd/ua-handling in meta-oe/recipes-extended/rsyslog/rsyslog_7.6.1.bb.
> 
> In my opinion this code
> 
>     if bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
>         pn = d.getVar('PN', True)
>         d.appendVar('ALTERNATIVE_%s' % (pn), ' syslog-service')
>         d.setVarFlag('ALTERNATIVE_LINK_NAME', 'syslog-service', '%s/systemd/system/syslog.service' % (d.getVar('sysconfdir', True)))
>         d.setVarFlag('ALTERNATIVE_TARGET', 'syslog-service', '%s/system/rsyslog.service' % (d.getVar('systemd_unitdir', True)))
> 
> registers the systemd service file under the (ua-)name "syslog-service". So it should not be
> 
>   SYSTEMD_SERVICE_${PN} = "${BPN}.service"
> 
> but
> 
>   SYSTEMD_SERVICE_${PN} = "syslog.service"
> 
> Right?

Hi experts! Is my assumption correct? If yes i would prepare patches for master, fido and jethro.

-- 
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058


  reply	other threads:[~2015-11-17  8:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 11:28 rsyslog: buggy systemd/ua handling? Steffen Sledz
2015-11-17  8:08 ` Steffen Sledz [this message]
     [not found]   ` <564CA3F8.9020404@dresearch-fe.de>
2015-11-19 14:34     ` systemd service vs. update-alternatives (was rsyslog: buggy systemd/ua handling?) Steffen Sledz
2015-11-20  9:06       ` ChenQi
2015-11-20 13:42         ` Steffen Sledz
2015-11-23 10:26           ` Steffen Sledz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564AE081.30004@dresearch-fe.de \
    --to=sledz@dresearch-fe.de \
    --cc=Martin.Jansa@gmail.com \
    --cc=Qi.Chen@windriver.com \
    --cc=akuster808@gmail.com \
    --cc=kai.kang@windriver.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.