From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Subject: Re: [PATCH RFC 3/3] Revert "libxc: create an initial
 FPU state for HVM guests"
Date: Tue, 17 Nov 2015 12:16:40 +0000
Message-ID: <564B1AA8.2040405@citrix.com>
References: <1444839880-15260-1-git-send-email-roger.pau@citrix.com>
	<1444839880-15260-4-git-send-email-roger.pau@citrix.com>
	<20151014163007.GA16650@zion.uk.xensource.com>
	<1447678263.27871.75.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=756d4e53c=roger.pau@citrix.com>)
	id 1ZyfBl-0002C3-I4
	for xen-devel@lists.xenproject.org; Tue, 17 Nov 2015 12:16:45 +0000
In-Reply-To: <1447678263.27871.75.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xenproject.org, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, Andrew Cooper <andrew.cooper3@citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 16/11/15 a les 12.51, Ian Campbell ha escrit:
> On Wed, 2015-10-14 at 17:30 +0100, Wei Liu wrote:
>> On Wed, Oct 14, 2015 at 06:24:40PM +0200, Roger Pau Monne wrote:
>>> This reverts commit d64dbbcc7c9934a46126c59d78536235908377ad.
>>>
>>> Xen always set the FPU as initialized when loading a HVM context, so
>>> libxc
>>> has to provide a valid FPU context when setting the CPU registers.
>>>
>>> This is a stop-gap measure in order to unblock OSSTest Windows 7
>>> failures
>>> while a proper fix for the HVM CPU save/restore is being worked on.
>>
>> I think it is better to say in the commit message that a proper fix is
>> in place so we can revert the stop-gap patch instead of copying the
>> commit message from the patch this is being reverted.
>>
>> Assuming I'm right about a proper fix will be committed before this
>> patch and the commit message fixed:
> 
> Roger, Is the "proper fix" in tree now? If so then please can we get an
> updated commit message which references that as Wei suggests.
> 
> I can update the message upon commit if you just want to provide the words,
> or feel free to resend of course.

No, a proper fix is still not in place, sorry. Let me see if I can get a
new version out today.

Roger.