All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init
Date: Tue, 17 Nov 2015 13:22:52 +0100	[thread overview]
Message-ID: <564B1C1C.7070801@linaro.org> (raw)
In-Reply-To: <5645D5A0.1000502@sigmadesigns.com>

On 11/13/2015 01:20 PM, Marc Gonzalez wrote:
> On 13/11/2015 11:58, Daniel Lezcano wrote:
>
>> The current code to initialize, register and read the clocksource is
>> already factored out in mmio.c via the clocksource_mmio_init function.
>>
>> Factor out the code with the clocksource_mmio_init function.
>
> The reason I didn't like clocksource_mmio_init() is because it exports
> 4 generic accessors.
>
> I guess this function makes more sense when all platforms are using it,
> in an ARCH_MULTIPLATFORM kernel. (Also the accessors are probably quite
> small, so the waste is probably minimal.)

Hi Marc,

it is not clear for me if you agree with this patch or not. Can you 
clarify ?

Thanks

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init
Date: Tue, 17 Nov 2015 13:22:52 +0100	[thread overview]
Message-ID: <564B1C1C.7070801@linaro.org> (raw)
In-Reply-To: <5645D5A0.1000502@sigmadesigns.com>

On 11/13/2015 01:20 PM, Marc Gonzalez wrote:
> On 13/11/2015 11:58, Daniel Lezcano wrote:
>
>> The current code to initialize, register and read the clocksource is
>> already factored out in mmio.c via the clocksource_mmio_init function.
>>
>> Factor out the code with the clocksource_mmio_init function.
>
> The reason I didn't like clocksource_mmio_init() is because it exports
> 4 generic accessors.
>
> I guess this function makes more sense when all platforms are using it,
> in an ARCH_MULTIPLATFORM kernel. (Also the accessors are probably quite
> small, so the waste is probably minimal.)

Hi Marc,

it is not clear for me if you agree with this patch or not. Can you 
clarify ?

Thanks

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  parent reply	other threads:[~2015-11-17 12:22 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 10:58 [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init Daniel Lezcano
2015-11-13 12:20 ` Marc Gonzalez
2015-11-13 12:20   ` Marc Gonzalez
2015-11-13 14:16   ` Daniel Lezcano
2015-11-13 14:16     ` Daniel Lezcano
2015-11-13 14:39     ` Marc Gonzalez
2015-11-13 14:39       ` Marc Gonzalez
2015-11-13 15:26       ` Thomas Gleixner
2015-11-13 15:26         ` Thomas Gleixner
2015-11-13 15:39         ` Marc Gonzalez
2015-11-13 15:39           ` Marc Gonzalez
2015-11-17 12:22   ` Daniel Lezcano [this message]
2015-11-17 12:22     ` Daniel Lezcano
2015-11-17 12:48     ` Marc Gonzalez
2015-11-17 12:48       ` Marc Gonzalez
2015-11-17 13:08       ` Måns Rullgård
2015-11-17 13:08         ` Måns Rullgård
2015-11-17 13:11       ` Daniel Lezcano
2015-11-17 13:11         ` Daniel Lezcano
2015-11-13 13:33 ` Marc Gonzalez
2015-11-13 14:18   ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564B1C1C.7070801@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.