Re: [meta-browser][PATCH 2/2] chromium: use PARALLEL_MAKE to control build parallelism

[Nikolay Dimitrov <picmaster@mail.bg>]

Hi Andre,

On 11/16/2015 08:15 PM, Andre McCurdy wrote:
> Hi Nikolay,
>
> On Sat, Nov 14, 2015 at 6:04 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>> Hi Andre,
>>
>> On 11/11/2015 06:48 AM, Andre McCurdy wrote:
>>>
>>> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
>>> ---
>>>    recipes-browser/chromium/chromium_40.0.2214.91.bb | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/recipes-browser/chromium/chromium_40.0.2214.91.bb
>>> b/recipes-browser/chromium/chromium_40.0.2214.91.bb
>>> index a9635cd..f20610c 100644
>>> --- a/recipes-browser/chromium/chromium_40.0.2214.91.bb
>>> +++ b/recipes-browser/chromium/chromium_40.0.2214.91.bb
>>> @@ -196,7 +196,7 @@ do_configure_append() {
>>>
>>>    do_compile() {
>>>            # build with ninja
>>> -        ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} -j${BB_NUMBER_THREADS}
>>> chrome chrome_sandbox
>>> +        ninja -C ${S}/out/${CHROMIUM_BUILD_TYPE} ${PARALLEL_MAKE} chrome
>>> chrome_sandbox
>>>    }
>>
>>
>> Can you please share the chromium build times on your build-box with
>> and without this patch? I'm just curious how well this worked for you.
>
> By default BB_NUMBER_THREADS and PARALLEL_MAKE are both derived from
> the number of logical CPU cores (as detected by oe.utils.cpu_count()),
> so the patch should not have any effect on build times.
>
> The patch is about correctness - it's not really right to use
> BB_NUMBER_THREADS for anything other than setting the maximum number
> of BitBake threads.

Ahh, I see. Thanks.

Regards,
Nikolay