From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, "Rafał Miłecki" <zajec5@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH 1/3] mtd: m25p80: fix module autoloading for "jedec,spi-nor" and "spi-nor"
Date: Tue, 17 Nov 2015 10:55:04 -0300 [thread overview]
Message-ID: <564B31B8.70104@osg.samsung.com> (raw)
In-Reply-To: <1447713292-91525-2-git-send-email-computersforpeace@gmail.com>
Hello Brian,
On 11/16/2015 07:34 PM, Brian Norris wrote:
> Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for
> "jedec,spi-nor"") moved the "jedec,spi-nor" handling from the
> spi_device_id table to the of_match_table, to better handle matching
> complex device tree compatible strings. With that patch, device tree
> support works as expected when m25p80.c is built into the kernel.
>
> However, that commit ignored the fact that:
>
> (1) (non-DT) platform devices might want to use the "spi-nor" string
> for matching with this driver, rather than picking an arbitrary one
> like "m25p80"
> (2) the core SPI uevent/modalias code doesn't yet support kernel module
> autoloading via of_match_table strings; so for DT-based devices, it
> will only report (part of) the first compatible string used
>
Very nice changelog message!
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2015-11-17 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 22:34 [PATCH 0/3] mtd: m25p80: fix some module and documentation issues Brian Norris
2015-11-16 22:34 ` Brian Norris
2015-11-16 22:34 ` [PATCH 1/3] mtd: m25p80: fix module autoloading for "jedec, spi-nor" and "spi-nor" Brian Norris
2015-11-16 22:34 ` [PATCH 1/3] mtd: m25p80: fix module autoloading for "jedec,spi-nor" " Brian Norris
2015-11-17 13:55 ` Javier Martinez Canillas [this message]
2015-11-16 22:34 ` [PATCH 2/3] mtd: m25p80: replace leftover "nor-jedec" with "spi-nor" in comments Brian Norris
2015-11-17 13:55 ` Javier Martinez Canillas
2015-11-16 22:34 ` [PATCH 3/3] doc: dt: mtd: stop referring to driver code for spi-nor IDs Brian Norris
2015-11-16 22:34 ` Brian Norris
2015-11-16 23:16 ` Rob Herring
2015-11-16 23:16 ` Rob Herring
2015-11-17 14:04 ` Javier Martinez Canillas
2015-11-17 14:04 ` Javier Martinez Canillas
2015-11-18 19:43 ` Brian Norris
2015-11-18 19:43 ` Brian Norris
2015-11-18 20:23 ` Javier Martinez Canillas
2015-11-18 20:23 ` Javier Martinez Canillas
2015-11-20 0:48 ` [PATCH 0/3] mtd: m25p80: fix some module and documentation issues Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564B31B8.70104@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=computersforpeace@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.