From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danilo Cesar Lemes de Paula Subject: Re: [PATCH v2 2/4] scripts/kernel-doc: Replacing highlights hash by an array Date: Tue, 17 Nov 2015 13:48:06 -0200 Message-ID: <564B4C36.2000004@collabora.co.uk> References: <1438112718-12168-1-git-send-email-danilo.cesar@collabora.co.uk> <1438112718-12168-3-git-send-email-danilo.cesar@collabora.co.uk> <20151117084046.5c911c6a@recife.lan> <20151117074431.01338392@lwn.net> <20151117132949.2c70d92f@recife.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20151117132949.2c70d92f@recife.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mauro Carvalho Chehab , Jonathan Corbet Cc: Michal Marek , Herbert Xu , linux-doc@vger.kernel.org, Stephan Mueller , Daniel Vetter , intel-gfx , Randy Dunlap , linux-kernel@vger.kernel.org, dri-devel , Laurent Pinchart , LMML List-Id: dri-devel@lists.freedesktop.org Ck9uIDE3LTExLTIwMTUgMTM6MjksIE1hdXJvIENhcnZhbGhvIENoZWhhYiB3cm90ZToKPiBFbSBU dWUsIDE3IE5vdiAyMDE1IDA3OjQ0OjMxIC0wNzAwCj4gSm9uYXRoYW4gQ29yYmV0IDxjb3JiZXRA bHduLm5ldD4gZXNjcmV2ZXU6Cj4gCj4+IE9uIFR1ZSwgMTcgTm92IDIwMTUgMDg6NDA6NDYgLTAy MDAKPj4gTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIDxtY2hlaGFiQG9zZy5zYW1zdW5nLmNvbT4gd3Jv dGU6Cj4+Cj4+PiBUaGUgYWJvdmUgY2F1c2VzIHNvbWUgdmVyc2lvbnMgb2YgcGVybCB0byBmYWls LCBhcyBrZXlzIGV4cGVjdCBhCj4+PiBoYXNoIGFyZ3VtZW50Ogo+Pj4KPj4+IEV4ZWN1dGlvbiBv ZiAuLy9zY3JpcHRzL2tlcm5lbC1kb2MgYWJvcnRlZCBkdWUgdG8gY29tcGlsYXRpb24gZXJyb3Jz Lgo+Pj4gVHlwZSBvZiBhcmcgMSB0byBrZXlzIG11c3QgYmUgaGFzaCAobm90IHByaXZhdGUgYXJy YXkpIGF0IC4vL3NjcmlwdHMva2VybmVsLWRvYyBsaW5lIDI3MTQsIG5lYXIgIkBoaWdobGlnaHRz KSAiCj4+Pgo+Pj4gVGhpcyBpcyBoYXBwZW5pbmcgYXQgbGludXh0di5vcmcgc2VydmVyLCB3aXRo IHJ1bnMgcGVybCB2ZXJzaW9uIDUuMTAuMS4KPj4KPj4gT0ssIHRoYXQncyBub3QgZ29vZC4gIEJ1 dCBJJ20gbm90IHF1aXRlIHN1cmUgd2hhdCB0byBkbyBhYm91dCBpdC4KPj4KPj4gUGVybCA1LjEw LjEgaXMgYSBsaXR0bGUgb3ZlciBzaXggeWVhcnMgb2xkLiAgTm9ib2R5IGVsc2UgaGFzIGNvbXBs YWluZWQKPj4gKHlldCkgYWJvdXQgdGhpcyBwcm9ibGVtLiAgU28gaXQgbWlnaHQgYmUgYmVzdCB0 byAiZml4IiB0aGlzIHdpdGggYQo+PiBtaW5pbXVtIHZlcnNpb24gYWRkZWQgdG8gdGhlIENoYW5n ZXMgZmlsZS4KPj4KPj4gT3IgbWF5YmUgd2UgbmVlZCB0byByZXZlcnQgdGhlIHBhdGNoLgo+Pgo+ PiBTbyBJJ20gZmFyIGZyb20gYSBQZXJsIGV4cGVydCwgc28gSSBoYXZlIG5vIGNsdWUgd2hhdCB0 aGUgbWluaW11bSB2ZXJzaW9uCj4+IHdvdWxkIGJlIGlmIHdlIHdlcmUgdG8gc2F5ICI1LjEwLjEg aXMgdG9vIG9sZC4iICBJIGRvbid0IHN1cHBvc2UgYW55Ym9keQo+PiBvdXQgdGhlcmUga25vd3M/ Cj4gCj4gSSdtIGFsc28gbm90IGEgUGVybCBleHBlcnQsIGFuZCBuZXZlciBzYXcgYmVmb3JlIHRo ZSB1c2FnZSBvZiAia2V5cyIgb24KPiBhbiBhcnJheS4gWWV0LCBhY2NvcmRpbmcgd2l0aDoKPiAJ aHR0cDovL3Blcmxkb2MucGVybC5vcmcvZnVuY3Rpb25zL2tleXMuaHRtbAo+IAo+ICJpbiBQZXJs IDUuMTIgb3IgbGF0ZXIgb25seSwgdGhlIGluZGljZXMgb2YgYW4gYXJyYXkiCj4gCj4gSWYgc28s IHRoZW4gbWF5YmUgd2UgY291bGQgcmVwbGFjZToKPiAJZm9yZWFjaCBteSAkayAoa2V5cyBAaGln aGxpZ2h0cykKPiAKPiBieSBhIG1vcmUgQyBzdHlsZSB2YXJpYW50LCB3aXRoIGFsbCB2ZXJzaW9u cyBvZiBwZXJsIDU6Cj4gCWZvciAobXkgJGsgPSAwOyAkayA8IEBoaWdobGlnaHRzOyAkaysrKSB7 Cj4gCj4gVGhlIGVuY2xvc2VkIHBhdGNoIHNob3VsZCBkbyB0aGUgdHJpY2suIEkgdGVzdGVkIGl0 IHdpdGggcGVybCA1LjEwIGFuZCAKPiBwZXJsIDUuMjIgaXQgd29ya2VkIGZpbmUgd2l0aCBib3Ro IHZlcnNpb25zLgoKSSdtIE5vdCBhIHBlcmwgZ3VydSBteXNlbGYgZWl0aGVyID0vLgoKQnV0IHRo YW5rcyBmb3IgZml4aW5nIGl0IE1hdXJvIQoKRGFuaWxvCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bhuna.collabora.co.uk ([46.235.227.227]:50984 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbbKQP51 (ORCPT ); Tue, 17 Nov 2015 10:57:27 -0500 Subject: Re: [PATCH v2 2/4] scripts/kernel-doc: Replacing highlights hash by an array To: Mauro Carvalho Chehab , Jonathan Corbet References: <1438112718-12168-1-git-send-email-danilo.cesar@collabora.co.uk> <1438112718-12168-3-git-send-email-danilo.cesar@collabora.co.uk> <20151117084046.5c911c6a@recife.lan> <20151117074431.01338392@lwn.net> <20151117132949.2c70d92f@recife.lan> Cc: LMML , linux-doc@vger.kernel.org, Randy Dunlap , Daniel Vetter , Laurent Pinchart , Herbert Xu , Stephan Mueller , Michal Marek , linux-kernel@vger.kernel.org, intel-gfx , dri-devel From: Danilo Cesar Lemes de Paula Message-ID: <564B4C36.2000004@collabora.co.uk> Date: Tue, 17 Nov 2015 13:48:06 -0200 MIME-Version: 1.0 In-Reply-To: <20151117132949.2c70d92f@recife.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 17-11-2015 13:29, Mauro Carvalho Chehab wrote: > Em Tue, 17 Nov 2015 07:44:31 -0700 > Jonathan Corbet escreveu: > >> On Tue, 17 Nov 2015 08:40:46 -0200 >> Mauro Carvalho Chehab wrote: >> >>> The above causes some versions of perl to fail, as keys expect a >>> hash argument: >>> >>> Execution of .//scripts/kernel-doc aborted due to compilation errors. >>> Type of arg 1 to keys must be hash (not private array) at .//scripts/kernel-doc line 2714, near "@highlights) " >>> >>> This is happening at linuxtv.org server, with runs perl version 5.10.1. >> >> OK, that's not good. But I'm not quite sure what to do about it. >> >> Perl 5.10.1 is a little over six years old. Nobody else has complained >> (yet) about this problem. So it might be best to "fix" this with a >> minimum version added to the Changes file. >> >> Or maybe we need to revert the patch. >> >> So I'm far from a Perl expert, so I have no clue what the minimum version >> would be if we were to say "5.10.1 is too old." I don't suppose anybody >> out there knows? > > I'm also not a Perl expert, and never saw before the usage of "keys" on > an array. Yet, according with: > http://perldoc.perl.org/functions/keys.html > > "in Perl 5.12 or later only, the indices of an array" > > If so, then maybe we could replace: > foreach my $k (keys @highlights) > > by a more C style variant, with all versions of perl 5: > for (my $k = 0; $k < @highlights; $k++) { > > The enclosed patch should do the trick. I tested it with perl 5.10 and > perl 5.22 it worked fine with both versions. I'm Not a perl guru myself either =/. But thanks for fixing it Mauro! Danilo