Re: [Qemu-devel] [PATCH v2 5/5] vnc: distiguish between ipv4/ipv6 omitted vs set to off

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

On 11/17/2015 10:00 AM, Daniel P. Berrange wrote:
> The VNC code for interpreting QemuOpts does not currently
> distinguish between ipv4/ipv6 being omitted, and being
> set to 'off', because historically the 'ipv4' and 'ipv6'
> options were just flags which did not accept a value.
> 
> The upshot is that if someone runs
> 
>   $QEMU -vnc localhost:1,ipv6=off
> 
> QEMU still uses PF_UNSPEC and thus may still bind to IPv6,
> when it should use PF_INET.
> 
> This is another instance of the problem previously fixed
> for chardevs in
> 
>   commit b77e7c8e99f9ac726c4eaa2fc3461fd886017dc0
>   Author: Paolo Bonzini <pbonzini@redhat.com>
>   Date:   Mon Oct 12 15:35:16 2015 +0200
> 
>     qemu-sockets: fix conversion of ipv4/ipv6 JSON to QemuOpts
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  ui/vnc.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]