From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZyrIE-0003xw-JG for linux-mtd@lists.infradead.org; Wed, 18 Nov 2015 01:12:14 +0000 Subject: Re: [PATCH] mtd: brcmnand: drop unused subpage_read() support To: Brian Norris , , References: <1447722248-135635-1-git-send-email-computersforpeace@gmail.com> From: Ray Jui Message-ID: <564BD03A.4030309@broadcom.com> Date: Tue, 17 Nov 2015 17:11:22 -0800 MIME-Version: 1.0 In-Reply-To: <1447722248-135635-1-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 11/16/2015 5:04 PM, Brian Norris wrote: > AFAIR this driver was never tested with subpage read support, and this > code is currently unused because we don't set the NAND_SUBPAGE_READ > flag. It can be resurrected if someone tests it properly. > > Signed-off-by: Brian Norris > --- > drivers/mtd/nand/brcmnand/brcmnand.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c > index 2a437c7ed175..569d57b5a180 100644 > --- a/drivers/mtd/nand/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/brcmnand/brcmnand.c > @@ -1546,16 +1546,6 @@ static int brcmnand_read_oob_raw(struct mtd_info *mtd, struct nand_chip *chip, > return 0; > } > > -static int brcmnand_read_subpage(struct mtd_info *mtd, struct nand_chip *chip, > - uint32_t data_offs, uint32_t readlen, > - uint8_t *bufpoi, int page) > -{ > - struct brcmnand_host *host = chip->priv; > - > - return brcmnand_read(mtd, chip, host->last_addr + data_offs, > - readlen >> FC_SHIFT, (u32 *)bufpoi, NULL); > -} > - > static int brcmnand_write(struct mtd_info *mtd, struct nand_chip *chip, > u64 addr, const u32 *buf, u8 *oob) > { > @@ -1944,7 +1934,6 @@ static int brcmnand_init_cs(struct brcmnand_host *host) > > chip->ecc.mode = NAND_ECC_HW; > chip->ecc.read_page = brcmnand_read_page; > - chip->ecc.read_subpage = brcmnand_read_subpage; > chip->ecc.write_page = brcmnand_write_page; > chip->ecc.read_page_raw = brcmnand_read_page_raw; > chip->ecc.write_page_raw = brcmnand_write_page_raw; > Sanity tested on Cygnus WA board. Finished booting to command prompt with UBIFS based rootfs. Thanks! Tested-by: Ray Jui Ray