From: Paolo Bonzini <pbonzini@redhat.com>
To: Huaitong Han <huaitong.han@intel.com>, gleb@kernel.org
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v3 7/7] KVM, pkeys: disable PKU feature without ept
Date: Wed, 18 Nov 2015 10:06:42 +0100 [thread overview]
Message-ID: <564C3FA2.9050104@redhat.com> (raw)
In-Reply-To: <1447825444-13550-8-git-send-email-huaitong.han@intel.com>
On 18/11/2015 06:44, Huaitong Han wrote:
> This patch disables CPUID:PKU without ept, becase pkeys is not supported
> with softmmu.
Sure, but _what_ makes it impossible to support pkeys with shadow pages?
Is it enough to add the pkey bits to the role (and then to
kvm_get_mmu_page, mmu_set_spte, set_spte) or are there fundamental problems?
The trick to handle !CR0.WP in FNAME(page_fault) (search for
"walker.pte_access &= ~ACC_USER_MASK"; it's documented in
Documentation/virtual/kvm/mmu.txt as well) should work for PKRU.
If you just want me to change it to "is not yet implemented for shadow
paging", I can do that.
Thanks,
Paolo
> Signed-off-by: Huaitong Han <huaitong.han@intel.com>
next prev parent reply other threads:[~2015-11-18 9:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 5:43 [PATCH v3 0/7] KVM, pkeys: add memory protection-key support Huaitong Han
2015-11-18 5:43 ` [PATCH v3 1/7] KVM, pkeys: expose CPUID/CR4 to guest Huaitong Han
2015-11-18 5:43 ` [PATCH v3 2/7] KVM, pkeys: disable pkeys for guests in non-paging mode Huaitong Han
2015-11-18 5:44 ` [PATCH v3 3/7] KVM, pkeys: update memeory permission bitmask for pkeys Huaitong Han
2015-11-18 5:44 ` [PATCH v3 4/7] KVM, pkeys: add pkeys support for permission_fault logic Huaitong Han
2015-11-18 5:44 ` [PATCH v3 5/7] KVM, pkeys: Add pkeys support for gva_to_gpa funcions Huaitong Han
2015-11-18 5:44 ` [PATCH v3 6/7] KVM, pkeys: add pkeys support for xsave state Huaitong Han
2015-11-18 5:44 ` [PATCH v3 7/7] KVM, pkeys: disable PKU feature without ept Huaitong Han
2015-11-18 9:06 ` Paolo Bonzini [this message]
2015-11-18 9:58 ` Han, Huaitong
2015-11-18 11:01 ` [PATCH v3 0/7] KVM, pkeys: add memory protection-key support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564C3FA2.9050104@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=huaitong.han@intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.