From: Lars-Peter Clausen <lars@metafoo.de>
To: Dragos Bogdan <dragos.bogdan@analog.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging:iio:ad7780: Switch to the gpio descriptor interface
Date: Wed, 18 Nov 2015 11:26:55 +0100 [thread overview]
Message-ID: <564C526F.7050506@metafoo.de> (raw)
In-Reply-To: <1447842205-3422-1-git-send-email-dragos.bogdan@analog.com>
On 11/18/2015 11:23 AM, Dragos Bogdan wrote:
> Use the gpiod interface for the powerdown_gpio instead of the deprecated
> old non-descriptor interface.
>
> The powerdown pin can be tied high, so the gpio is optional.
> Remove the gpio_pdrst platform_data member since the new interface is
> used.
>
> Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
Thanks, looks mostly good. One comment inline.
> ---
> drivers/staging/iio/adc/ad7780.c | 26 +++++++++++---------------
> drivers/staging/iio/adc/ad7780.h | 1 -
> 2 files changed, 11 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
> index 618b41f..a5c5a95 100644
> --- a/drivers/staging/iio/adc/ad7780.c
> +++ b/drivers/staging/iio/adc/ad7780.c
> @@ -16,6 +16,7 @@
> #include <linux/err.h>
> #include <linux/sched.h>
> #include <linux/gpio.h>
I think this include can be removed now.
[...]
prev parent reply other threads:[~2015-11-18 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 10:23 [PATCH] staging:iio:ad7780: Switch to the gpio descriptor interface Dragos Bogdan
2015-11-18 10:26 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564C526F.7050506@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.