From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v3 51/62] arm/acpi: Prepare EFI system table
 for Dom0
Date: Wed, 18 Nov 2015 12:06:00 +0000
Message-ID: <564C69A8.9030506@citrix.com>
References: <1447753261-7552-1-git-send-email-shannon.zhao@linaro.org>
	<1447753261-7552-52-git-send-email-shannon.zhao@linaro.org>
	<564B1757.5060008@citrix.com> <564BF1E2.5050003@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <564BF1E2.5050003@huawei.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Shannon Zhao <zhaoshenglong@huawei.com>, shannon.zhao@linaro.org, xen-devel@lists.xen.org
Cc: hangaohuai@huawei.com, stefano.stabellini@citrix.com, ian.campbell@citrix.com, peter.huangpeng@huawei.com
List-Id: xen-devel@lists.xenproject.org

On 18/11/15 03:34, Shannon Zhao wrote:
> On 2015/11/17 20:02, Julien Grall wrote:
>> I'm nearly sure I already said it, this code already exists in the tree.
>> Why do you need to implement a new version?
> Ok, it needs to move the functions to the public place, right? So they
> can be called from other places.

I don't think you need to move the current function code. AFAICT, it's
already exported by common/xz/crc32.c

Regards,

-- 
Julien Grall