From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc_gonzalez@sigmadesigns.com (Marc Gonzalez) Date: Wed, 18 Nov 2015 17:34:08 +0100 Subject: [PATCH v9 1/2] arm-soc: Import initial tango4 device tree In-Reply-To: References: <564C94A5.4060301@sigmadesigns.com> <564C94FD.60607@sigmadesigns.com> Message-ID: <564CA880.1030502@sigmadesigns.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18/11/2015 17:05, M?ns Rullg?rd wrote: > Marc Gonzalez wrote: > >> + clkgen: clkgen at 10000 { >> + compatible = "sigma,tango4-clkgen"; >> + reg = <0x10000 0x40>; >> + clocks = <&xtal>; >> + clock-output-names = "cpuclk", "sysclk"; >> + #clock-cells = <1>; >> + }; > > Would you please consider using my clock driver that matches the actual > hardware, supports all the clock outputs required for USB, SATA, etc, > and works on tango3 as well? I was hoping to take baby steps to work up to a fully-functional port. The first step (in my mind) is this submission: a minimal port which only requires the two "main" clocks. The next step will add to the minimal port by supporting as many peripherals as possible, as well as their required clocks. Would you agree to discuss the clkgen driver in a few weeks, when I can concentrate full-time on the subject? Working on other drivers will give me a better understanding of the required clocks. I've also been talking internally with our firmware writers, and with the clk maintainers to get a better picture of the whole mess. (Note that the next chip will come with a brand new clkgen block, much more sane.) Regards.