From: Ian Abbott <abbotti@mev.co.uk>
To: Ranjith Thangavel <ranjithece24@gmail.com>, gregkh@linuxfoundation.org
Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro
Date: Wed, 18 Nov 2015 16:34:57 +0000 [thread overview]
Message-ID: <564CA8B1.8080404@mev.co.uk> (raw)
In-Reply-To: <564CA6CC.6010600@mev.co.uk>
On 18/11/15 16:26, Ian Abbott wrote:
> On 14/11/15 17:10, Ranjith Thangavel wrote:
>> BIT macro is used for defining BIT location instead of
>> shifting operator, usleep_range is preferred over
>> udelay - coding style issue
>
> Those two things should be done in separate patches.
Sorry, I didn't see you've reposted this as two separate patches, so
ignore my previous reply.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-11-18 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 17:10 [PATCH] comedi: dmm32at: Fix coding style - use BIT macro Ranjith Thangavel
2015-11-16 14:43 ` Dan Carpenter
2015-11-18 16:26 ` Ian Abbott
2015-11-18 16:34 ` Ian Abbott [this message]
2015-11-19 7:51 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2015-11-16 17:09 Ranjith Thangavel
2015-11-16 17:21 ` Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564CA8B1.8080404@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.