All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Hentschel" <nerv@dawncrow.de>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] wine: Bump to 1.8
Date: Wed, 18 Nov 2015 23:19:13 +0100	[thread overview]
Message-ID: <564CF961.3010305@dawncrow.de> (raw)
In-Reply-To: <20151118225702.23400c0f@free-electrons.com>

Am 18.11.2015 um 22:57 schrieb Thomas Petazzoni:
> Hello,
> 
> On Wed, 18 Nov 2015 22:46:45 +0100, Andr? Hentschel wrote:
> 
>>>  * Use 'git format-patch -M' to enable rename detection, so that the
>>>    renaming of the patches is detected, and instead of seeing a
>>>    complete file being removed, and a complete file being added, we see
>>>    a rename.
>>
>> I also adjusted the patch a bit to apply to the new version
> 
> Not a problem: if the changes are not too important, it will still
> detect the rename.

OK, I'll try that

> 
>>> Last suggestion: can you submit the SANE_CONFIG patch upstream, so that
>>> hopefully they merge it before the 1.8 release, and we can have zero
>>> patches for the wine package ?
>>
>> The patch won't go in as it is, because it would break
>> non-cross-builds, also this problem is most likely not only true for
>> sane, but also for other *-config programs, and I'm no configure
>> guru...
> 
> Why do you say it breaks non-cross-builds? I looked again at
> 0003-sane-config-fix.patch and I don't really see how it can break
> non-cross-builds.
> 
> The patch is just replacing 'sane-config' by
> '${SANE_CONFIG:-sane-config}'.
> 
> ${SANE_CONFIG:-sane-config} says "use the value of SANE_CONFIG is
> available, otherwise use sane-config".
> 
> So, if SANE_CONFIG is not defined in the environment, this patch makes
> zero difference compared to the existing situation. It only optionally
> allows to pass SANE_CONFIG.
> 

True, my mistake, but the other points hold true.

      reply	other threads:[~2015-11-18 22:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 21:00 [Buildroot] [RFC] wine: Bump to 1.8 André Hentschel
2015-11-18 21:21 ` Thomas Petazzoni
2015-11-18 21:46   ` André Hentschel
2015-11-18 21:57     ` Thomas Petazzoni
2015-11-18 22:19       ` André Hentschel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564CF961.3010305@dawncrow.de \
    --to=nerv@dawncrow.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.