From: Bart Van Assche <bart.vanassche@sandisk.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Dan Williams <dan.j.williams@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2] Separate target visibility from reaped state information
Date: Wed, 18 Nov 2015 16:37:46 -0800 [thread overview]
Message-ID: <564D19DA.40006@sandisk.com> (raw)
In-Reply-To: <1447741343.5417.7.camel@HansenPartnership.com>
On 11/16/2015 10:22 PM, James Bottomley wrote:
> OK, could you justify this, please ... like with traces and things.
> [ ... ]
> If that isn't the case, we can fix it, but I'd like to see the evidence.
Hello James,
To my own surprise so far I have not yet been able to trigger a lockup
without this patch. After I had inserted an msleep() call at the start
of scsi_target_reap_ref_release() to delay the starget->state =
STARGET_DEL assignment I rebuilt and rebooted the kernel, started
multipathd and held a SCSI device open by creating a filesystem on it
and by mounting it. Next I removed all SRP targets (for p in
/sys/class/srp_remote_ports/*; do echo 1 >$p/delete & done). During this
test no lockup was reported.
Bart.
prev parent reply other threads:[~2015-11-19 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 0:18 [PATCH v2] Separate target visibility from reaped state information Bart Van Assche
2015-11-17 6:22 ` James Bottomley
2015-11-19 0:37 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564D19DA.40006@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.