From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933621AbbKSB5K (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Nov 2015 20:57:10 -0500
Received: from szxga01-in.huawei.com ([58.251.152.64]:34175 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754580AbbKSB5I (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Nov 2015 20:57:08 -0500
Subject: Re: [PATCH V6 RESEND 2/3] reset: hi6220: Reset driver for hisilicon
 hi6220 SoC
To: Philipp Zabel <p.zabel@pengutronix.de>
References: <1446175164-116524-1-git-send-email-puck.chen@hisilicon.com>
 <1446175164-116524-2-git-send-email-puck.chen@hisilicon.com>
 <1447867675.23650.0.camel@pengutronix.de>
CC: <linux-kernel@vger.kernel.org>, <puck.chen@aliyun.com>,
        <robh+dt@kernel.org>, <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>
From: chenfeng <puck.chen@hisilicon.com>
Message-ID: <564D2C68.1010209@hisilicon.com>
Date: Thu, 19 Nov 2015 09:56:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1447867675.23650.0.camel@pengutronix.de>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.142.192.172]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A010204.564D2C6F.0018,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 410cba8e7bd4299a7ba0a98512a2d0a2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Zabel,
On 2015/11/19 1:27, Philipp Zabel wrote:
> Am Freitag, den 30.10.2015, 11:19 +0800 schrieb Chen Feng:
>> Add reset driver for hi6220-hikey board,this driver supply deassert
>> of IP on hi6220 SoC.
>>
>> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> [...]
>> diff --git a/drivers/reset/hisilicon/Kconfig b/drivers/reset/hisilicon/Kconfig
>> new file mode 100644
>> index 0000000..26bf95a
>> --- /dev/null
>> +++ b/drivers/reset/hisilicon/Kconfig
>> @@ -0,0 +1,5 @@
>> +config COMMON_RESET_HI6220
>> +	tristate "Hi6220 Reset Driver"
>> +	depends on (ARCH_HISI && RESET_CONTROLLER)
>> +	help
>> +	  Build the Hisilicon Hi6220 reset driver.
> 
> Why is this configurable? Can't you just drop the Kconfig and use ...
> 
>> diff --git a/drivers/reset/hisilicon/Makefile b/drivers/reset/hisilicon/Makefile
>> new file mode 100644
>> index 0000000..c932f86
>> --- /dev/null
>> +++ b/drivers/reset/hisilicon/Makefile
>> @@ -0,0 +1 @@
>> +obj-$(CONFIG_COMMON_RESET_HI6220) += hi6220_reset.o
> 
> ... obj-$(CONFIG_ARCH_HISI) += hi6220_reset.o
> 
> here?
> 
Currently, the support SoC is hi6220 which is one of Kirin solution.

I can't use obj-$(CONFIG_ARCH_HISI) += hi6220_reset.o here.

Because,the hisilicon chip sets also have server chip(eg：D02，D03) and other solution.

The reset controller may be different.

> regards
> Philipp
> 
> 
> 
> .
>