From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v3 03/12] drm/rockchip: return a true clock rate to adjusted_mode Date: Thu, 19 Nov 2015 15:08:29 +0800 Message-ID: <564D756D.9050000@rock-chips.com> References: <1447904131-29328-1-git-send-email-zyw@rock-chips.com> <1447904131-29328-4-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1447904131-29328-4-git-send-email-zyw@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Zhong , heiko@sntech.de, linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDEx5pyIMTnml6UgMTE6MzUsIENocmlzIFpob25nIHdyb3RlOgo+ICsKPiArCS8q Cj4gKwkgKiBTb21ldGltZXMgdGhlIGNsb2NrIGRyaXZlciBjYW4gbm90IHNldCBhIGFjY3VyYXRl IGNsb2NrX3JhdGUgZm9yIHZvcCwKPiArCSAqIGdldCB0aGUgdHJ1ZSByYXRlIG9mIHZvcF9kY2xr IGFuZCBzZXQgaXQgYmFjayB0byBhZGp1c3RlZF9tb2RlLgo+ICsJICovCj4gKwlhZGp1c3RlZF9t b2RlLT5jbG9jayA9IGNsa19nZXRfcmF0ZSh2b3AtPmRjbGspIC8gMTAwMDsKPiAgIG91dDoKPiAg IAlyZXRfY2xrID0gY2xrX2VuYWJsZSh2b3AtPmRjbGspOwo+ICAgCWlmIChyZXRfY2xrIDwgMCkg ewpIaSBDaHJpcwogICAgICBIb3cgYWJvdXQgdXNlIGNsa19yb3VuZF9yYXRlIHRvIGNoZWNrIHRo ZSBjbG9jayByYXRlIGZpcnN0PwogICAgICBJIHRoaW5rIHdlIGNhbiBjaGVjayBpdCBvbiB2b3Bf Y3J0Y19tb2RlX2ZpeHVwLgoKVGhhbmtzLgotIO+8rWFyayBZYW8KCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Thu, 19 Nov 2015 15:08:29 +0800 Subject: [PATCH v3 03/12] drm/rockchip: return a true clock rate to adjusted_mode In-Reply-To: <1447904131-29328-4-git-send-email-zyw@rock-chips.com> References: <1447904131-29328-1-git-send-email-zyw@rock-chips.com> <1447904131-29328-4-git-send-email-zyw@rock-chips.com> Message-ID: <564D756D.9050000@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?11?19? 11:35, Chris Zhong wrote: > + > + /* > + * Sometimes the clock driver can not set a accurate clock_rate for vop, > + * get the true rate of vop_dclk and set it back to adjusted_mode. > + */ > + adjusted_mode->clock = clk_get_rate(vop->dclk) / 1000; > out: > ret_clk = clk_enable(vop->dclk); > if (ret_clk < 0) { Hi Chris How about use clk_round_rate to check the clock rate first? I think we can check it on vop_crtc_mode_fixup. Thanks. - ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933830AbbKSHIl (ORCPT ); Thu, 19 Nov 2015 02:08:41 -0500 Received: from regular1.263xmail.com ([211.150.99.134]:52727 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbbKSHIk (ORCPT ); Thu, 19 Nov 2015 02:08:40 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <247f50c672b18e7e84840bde1a1d1dc3> X-DNS-TYPE: 0 Message-ID: <564D756D.9050000@rock-chips.com> Date: Thu, 19 Nov 2015 15:08:29 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Chris Zhong , heiko@sntech.de, linux-rockchip@lists.infradead.org CC: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 03/12] drm/rockchip: return a true clock rate to adjusted_mode References: <1447904131-29328-1-git-send-email-zyw@rock-chips.com> <1447904131-29328-4-git-send-email-zyw@rock-chips.com> In-Reply-To: <1447904131-29328-4-git-send-email-zyw@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年11月19日 11:35, Chris Zhong wrote: > + > + /* > + * Sometimes the clock driver can not set a accurate clock_rate for vop, > + * get the true rate of vop_dclk and set it back to adjusted_mode. > + */ > + adjusted_mode->clock = clk_get_rate(vop->dclk) / 1000; > out: > ret_clk = clk_enable(vop->dclk); > if (ret_clk < 0) { Hi Chris How about use clk_round_rate to check the clock rate first? I think we can check it on vop_crtc_mode_fixup. Thanks. - Ｍark Yao