From: Panu Matilainen <pmatilai@redhat.com>
To: dev@dpdk.org
Subject: Re: [PATCH] Revert "eal: set name to threads"
Date: Thu, 19 Nov 2015 13:49:53 +0200 [thread overview]
Message-ID: <564DB761.5090203@redhat.com> (raw)
In-Reply-To: <1447932137-16886-1-git-send-email-ferruh.yigit@intel.com>
On 11/19/2015 01:22 PM, Ferruh Yigit wrote:
> This reverts commit 67b6d3039e9edbc4624c878c6930be5e126e8b58.
>
> Reverted patch uses pthread_setname_np() function, this function added
> into glibc in version 2.12 and cause a compile error in older glibc
> versions:
> error: implicit declaration of function "pthread_setname_np"
>
> Main purpose of reverted patch is to name threads, without
> pthread_setname_np() function, patch does not mean much, so reverting
> patch for sake of compatibility with older glibc versions.
>
Debuggability is important too. Rather than revert, why not wrap it in
rte_thread_setname() or such and just make it a no-op with glibc
versions where pthread_setname_np() is not available?
- Panu -
next prev parent reply other threads:[~2015-11-19 11:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 13:32 Compile errors with libc < 2.12 Ferruh Yigit
2015-11-18 14:24 ` Thomas Monjalon
2015-11-19 11:22 ` [PATCH] Revert "eal: set name to threads" Ferruh Yigit
2015-11-19 11:49 ` Panu Matilainen [this message]
2015-11-19 12:32 ` Thomas Monjalon
2015-11-19 13:39 ` Ferruh Yigit
2015-11-19 16:59 ` Ferruh Yigit
2015-11-19 17:44 ` [PATCH] eal: fix compile error for old glibc caused by pthread_setname_np() Ferruh Yigit
2015-11-20 12:21 ` [PATCH] eal: fix compile error for old glibc caused by pthread_setname_np()# Bruce Richardson
2015-11-24 14:26 ` Ferruh Yigit
2015-11-24 17:54 ` [PATCH] eal: fix compile error for old glibc caused by pthread_setname_np() Thomas Monjalon
2015-11-24 18:47 ` Ferruh Yigit
2015-11-25 11:13 ` [PATCH v2] " Ferruh Yigit
2015-11-25 11:18 ` Thomas Monjalon
2015-11-25 11:24 ` Ferruh Yigit
2015-11-25 11:30 ` Thomas Monjalon
2015-11-25 13:41 ` Thomas Monjalon
2015-11-25 13:51 ` Roger B. Melton
2015-11-25 14:03 ` Thomas Monjalon
2015-11-25 14:20 ` Roger B. Melton
2015-11-19 11:23 ` [PATCH] eal: fix compile error for old glibc caused by CLOCK_MONOTONIC_RAW Ferruh Yigit
2015-11-20 17:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564DB761.5090203@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.