From: Lars-Peter Clausen <lars@metafoo.de>
To: Dragos Bogdan <dragos.bogdan@analog.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Michael Hennerich <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging:iio:ad7780: Remove the ad7780_platform_data
Date: Thu, 19 Nov 2015 13:07:45 +0100 [thread overview]
Message-ID: <564DBB91.4010400@metafoo.de> (raw)
In-Reply-To: <1447856194-26450-1-git-send-email-dragos.bogdan@analog.com>
On 11/18/2015 03:16 PM, Dragos Bogdan wrote:
> The ad7780_platform_data contains just the reference voltage information.
> Since the preferred way of specifying this information is using the Linux
> regulator framework and the ad7780 platform_data is not used by other
> users, it can be completely removed.
>
> Signed-off-by: Dragos Bogdan <dragos.bogdan@analog.com>
Looks good, thanks.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Just one thing to consider for future patches...
[...]
> - dev_warn(&spi->dev, "reference voltage unspecified\n");
> + dev_warn(&spi->dev, "Reference voltage unspecified\n");
Strictly speaking this is a unrelated change and ideally would have been
split into a separate patch.
next prev parent reply other threads:[~2015-11-19 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 14:16 [PATCH] staging:iio:ad7780: Remove the ad7780_platform_data Dragos Bogdan
2015-11-19 12:07 ` Lars-Peter Clausen [this message]
2015-11-21 17:53 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564DBB91.4010400@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.