diff for duplicates of <564DBC88.5020508@redhat.com> diff --git a/a/1.txt b/N1/1.txt index b4002e1..70e74a9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -26,7 +26,7 @@ On 19/11/15 09:37, Christian Borntraeger wrote: > + int i; > + > + kvm_for_each_vcpu(i, vcpu, kvm) -> + if (vcpu->vcpu_id = id) +> + if (vcpu->vcpu_id == id) > + return vcpu; > + return NULL; > +} @@ -39,7 +39,7 @@ two functions that sound very similar and also have similar prototypes: - kvm_lookup_vcpu(struct kvm *kvm, int id) I'm pretty sure this will cause confusion in the future! -=> Could you maybe name the new function something like +==> Could you maybe name the new function something like "kvm_lookup_vcpu_by_id" or "kvm_get_vcpu_by_id" instead? Also a short comment before the function would be nice to make the diff --git a/a/content_digest b/N1/content_digest index 664e0e5..77374fe 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\01447922251-54261-2-git-send-email-borntraeger@de.ibm.com\0" "From\0Thomas Huth <thuth@redhat.com>\0" "Subject\0Re: [PATCH 1/4] KVM: Provide function for VCPU lookup by id\0" - "Date\0Thu, 19 Nov 2015 12:11:52 +0000\0" + "Date\0Thu, 19 Nov 2015 13:11:52 +0100\0" "To\0Christian Borntraeger <borntraeger@de.ibm.com>" Paolo Bonzini <pbonzini@redhat.com> Alexander Graf <agraf@suse.de> @@ -43,7 +43,7 @@ "> +\tint i;\n" "> +\n" "> +\tkvm_for_each_vcpu(i, vcpu, kvm)\n" - "> +\t\tif (vcpu->vcpu_id = id)\n" + "> +\t\tif (vcpu->vcpu_id == id)\n" "> +\t\t\treturn vcpu;\n" "> +\treturn NULL;\n" "> +}\n" @@ -56,7 +56,7 @@ "- kvm_lookup_vcpu(struct kvm *kvm, int id)\n" "\n" "I'm pretty sure this will cause confusion in the future!\n" - "=> Could you maybe name the new function something like\n" + "==> Could you maybe name the new function something like\n" "\"kvm_lookup_vcpu_by_id\" or \"kvm_get_vcpu_by_id\" instead?\n" "\n" "Also a short comment before the function would be nice to make the\n" @@ -67,4 +67,4 @@ "\n" Thomas -a2c10046f4766fc8eccd14d6298a57f05101eca29853c2a1fcbc1caf961e4cda +0c8b18347fe9952f29d011756fd36d23362ec2cbdd9a7975e963a39362d9a8ec
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.