From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Mans Rullgard <mans@mansr.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Nicolas Pitre <nico@linaro.org>, Tony Lindgren <tony@atomide.com>,
Sebastian Frias <sebastian_frias@sigmadesigns.com>
Subject: Re: [PATCH] clocksource: Store reg field within struct clocksource
Date: Thu, 19 Nov 2015 13:41:12 +0100 [thread overview]
Message-ID: <564DC368.2030104@sigmadesigns.com> (raw)
In-Reply-To: <20151119112130.GY8644@n2100.arm.linux.org.uk>
On 19/11/2015 12:21, Russell King wrote:
> When I wrote the MMIO clocksource implementation, there was no
> ____cacheline_aligned on struct clocksource, and the arrangement I came
> to for the structure put the 'reg' and 'read' within the same cache line
> (note that the MMIO clocksource pre-dates Thomas' rearrangement of struct
> clocksource and the addition of the cache line alignment.) The original
> layout did not have any padding gaps.
For the record, I pointed out the chronology in a previous discussion.
But Thomas didn't comment at the time :-(
http://thread.gmane.org/gmane.linux.ports.arm.kernel/402968/focus=403604
Mason wrote:
> Oh and while I have your attention ;-) I have alignment-related
> questions about clocksource_mmio_init() (commit 442c8176d2) wrt
> Thomas Gleixner's 369db4c952 patch. (I think the two patches
> do not play nice.)
Regards.
prev parent reply other threads:[~2015-11-19 12:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 13:43 [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez
2015-11-18 13:51 ` Måns Rullgård
2015-11-18 17:21 ` Russell King - ARM Linux
2015-11-19 9:27 ` Marc Gonzalez
2015-11-19 10:33 ` Russell King - ARM Linux
2015-11-19 10:36 ` Thomas Gleixner
2015-11-19 10:40 ` Russell King - ARM Linux
2015-11-19 10:33 ` Thomas Gleixner
2015-11-19 10:36 ` Russell King - ARM Linux
2015-11-19 10:42 ` Thomas Gleixner
2015-11-19 11:08 ` Russell King - ARM Linux
2015-11-19 11:14 ` Thomas Gleixner
2015-11-19 12:26 ` Marc Gonzalez
2015-11-19 13:57 ` Thomas Gleixner
2015-11-24 12:36 ` Marc Gonzalez
2015-11-25 21:33 ` [tip:timers/core] timekeeping: Lift clocksource cacheline restriction tip-bot for Thomas Gleixner
2015-11-19 10:55 ` [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez
2015-11-19 11:21 ` Russell King - ARM Linux
2015-11-19 12:41 ` Marc Gonzalez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564DC368.2030104@sigmadesigns.com \
--to=marc_gonzalez@sigmadesigns.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mans@mansr.com \
--cc=nico@linaro.org \
--cc=sebastian_frias@sigmadesigns.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.