From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) Date: Thu, 19 Nov 2015 21:47:05 +0100 Subject: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes In-Reply-To: <1447672194-483-2-git-send-email-jszhang@marvell.com> References: <1447672194-483-1-git-send-email-jszhang@marvell.com> <1447672194-483-2-git-send-email-jszhang@marvell.com> Message-ID: <564E3549.2050700@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16.11.2015 12:09, Jisheng Zhang wrote: > The Marvell Berlin BG2Q has 3 watchdogs which are compatible with the > snps,dw-wdt driver sit in the sysmgr domain. This patch adds the > corresponding device tree nodes. > > Signed-off-by: Jisheng Zhang > --- > arch/arm/boot/dts/berlin2q.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi > index a3ecde5..fac4315 100644 > --- a/arch/arm/boot/dts/berlin2q.dtsi > +++ b/arch/arm/boot/dts/berlin2q.dtsi > @@ -483,6 +483,30 @@ > ranges = <0 0xfc0000 0x10000>; > interrupt-parent = <&sic>; > > + wdt0: watchdog at 1000 { > + compatible = "snps,dw-wdt"; > + reg = <0x1000 0x100>; > + clocks = <&refclk>; > + interrupts = <0>; > + status = "disabled"; Jisheng, as the watchdogs are internal and cannot be clock gated at all, how about we remove the status = "disabled" and make them always available? I have applied patches 1-4 with the status property removed. This also renders patches 5-8 useless. So, for now tentatively Appled to berlin/dt and berlin64/dt respectivly with status property removed. Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Hesselbarth Subject: Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes Date: Thu, 19 Nov 2015 21:47:05 +0100 Message-ID: <564E3549.2050700@gmail.com> References: <1447672194-483-1-git-send-email-jszhang@marvell.com> <1447672194-483-2-git-send-email-jszhang@marvell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447672194-483-2-git-send-email-jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jisheng Zhang , robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 16.11.2015 12:09, Jisheng Zhang wrote: > The Marvell Berlin BG2Q has 3 watchdogs which are compatible with the > snps,dw-wdt driver sit in the sysmgr domain. This patch adds the > corresponding device tree nodes. > > Signed-off-by: Jisheng Zhang > --- > arch/arm/boot/dts/berlin2q.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi > index a3ecde5..fac4315 100644 > --- a/arch/arm/boot/dts/berlin2q.dtsi > +++ b/arch/arm/boot/dts/berlin2q.dtsi > @@ -483,6 +483,30 @@ > ranges = <0 0xfc0000 0x10000>; > interrupt-parent = <&sic>; > > + wdt0: watchdog@1000 { > + compatible = "snps,dw-wdt"; > + reg = <0x1000 0x100>; > + clocks = <&refclk>; > + interrupts = <0>; > + status = "disabled"; Jisheng, as the watchdogs are internal and cannot be clock gated at all, how about we remove the status = "disabled" and make them always available? I have applied patches 1-4 with the status property removed. This also renders patches 5-8 useless. So, for now tentatively Appled to berlin/dt and berlin64/dt respectivly with status property removed. Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964834AbbKSUrL (ORCPT ); Thu, 19 Nov 2015 15:47:11 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:33871 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934150AbbKSUrJ (ORCPT ); Thu, 19 Nov 2015 15:47:09 -0500 Subject: Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes To: Jisheng Zhang , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com References: <1447672194-483-1-git-send-email-jszhang@marvell.com> <1447672194-483-2-git-send-email-jszhang@marvell.com> Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Sebastian Hesselbarth Message-ID: <564E3549.2050700@gmail.com> Date: Thu, 19 Nov 2015 21:47:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <1447672194-483-2-git-send-email-jszhang@marvell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.11.2015 12:09, Jisheng Zhang wrote: > The Marvell Berlin BG2Q has 3 watchdogs which are compatible with the > snps,dw-wdt driver sit in the sysmgr domain. This patch adds the > corresponding device tree nodes. > > Signed-off-by: Jisheng Zhang > --- > arch/arm/boot/dts/berlin2q.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi > index a3ecde5..fac4315 100644 > --- a/arch/arm/boot/dts/berlin2q.dtsi > +++ b/arch/arm/boot/dts/berlin2q.dtsi > @@ -483,6 +483,30 @@ > ranges = <0 0xfc0000 0x10000>; > interrupt-parent = <&sic>; > > + wdt0: watchdog@1000 { > + compatible = "snps,dw-wdt"; > + reg = <0x1000 0x100>; > + clocks = <&refclk>; > + interrupts = <0>; > + status = "disabled"; Jisheng, as the watchdogs are internal and cannot be clock gated at all, how about we remove the status = "disabled" and make them always available? I have applied patches 1-4 with the status property removed. This also renders patches 5-8 useless. So, for now tentatively Appled to berlin/dt and berlin64/dt respectivly with status property removed. Sebastian