Re: [PATCH 1/1] usb: phy: omap-otg: do not write to unallocated memory

[Chanwoo Choi <cw00.choi@samsung.com>]

Hi,

The same patch was already reviewed and applied on usb.git repository[1]
[1] https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes&id=2c2025b41aeff57963f9ae2dd909fea704c625ab

Thanks,
Chanwoo Choi

On 2015년 11월 20일 08:43, Heinrich Schuchardt wrote:
> The current coding writes to memory before allocating it.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  drivers/usb/phy/phy-omap-otg.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/phy/phy-omap-otg.c b/drivers/usb/phy/phy-omap-otg.c
> index 1270906..8bbf121 100644
> --- a/drivers/usb/phy/phy-omap-otg.c
> +++ b/drivers/usb/phy/phy-omap-otg.c
> @@ -105,12 +105,13 @@ static int omap_otg_probe(struct platform_device *pdev)
>  	extcon = extcon_get_extcon_dev(config->extcon);
>  	if (!extcon)
>  		return -EPROBE_DEFER;
> -	otg_dev->extcon = extcon;
>  
>  	otg_dev = devm_kzalloc(&pdev->dev, sizeof(*otg_dev), GFP_KERNEL);
>  	if (!otg_dev)
>  		return -ENOMEM;
>  
> +	otg_dev->extcon = extcon;
> +
>  	otg_dev->base = devm_ioremap_resource(&pdev->dev, &pdev->resource[0]);
>  	if (IS_ERR(otg_dev->base))
>  		return PTR_ERR(otg_dev->base);
>